Yes.
On Fri, Nov 17, 2017 at 12:30 PM Oliver Pinter < oliver.pin...@hardenedbsd.org> wrote: > > > On Friday, November 17, 2017, Conrad Meyer <c...@freebsd.org> wrote: > >> Author: cem >> Date: Fri Nov 17 19:25:39 2017 >> New Revision: 325957 >> URL: https://svnweb.freebsd.org/changeset/base/325957 >> >> Log: >> vfs_lookup: Allow PATH_MAX-1 symlinks >> >> Previously, symlinks in FreeBSD were artificially limited to PATH_MAX-2. >> >> Add a short test case to verify the change. >> >> Submitted by: Gaurav Gangalwar <ggangalwar AT isilon.com> >> Reviewed by: kib >> Sponsored by: Dell EMC Isilon >> Differential Revision: https://reviews.freebsd.org/D12589 >> >> Added: >> head/tests/sys/vfs/lookup_test.sh (contents, props changed) >> Modified: >> head/sys/kern/vfs_lookup.c >> head/tests/sys/vfs/Makefile >> >> Modified: head/sys/kern/vfs_lookup.c >> >> ============================================================================== >> --- head/sys/kern/vfs_lookup.c Fri Nov 17 19:10:10 2017 (r325956) >> +++ head/sys/kern/vfs_lookup.c Fri Nov 17 19:25:39 2017 (r325957) >> @@ -499,7 +499,7 @@ namei(struct nameidata *ndp) >> error = ENOENT; >> break; >> } >> - if (linklen + ndp->ni_pathlen >= MAXPATHLEN) { >> + if (linklen + ndp->ni_pathlen > MAXPATHLEN) { >> if (ndp->ni_pathlen > 1) >> uma_zfree(namei_zone, cp); >> error = ENAMETOOLONG; >> >> Modified: head/tests/sys/vfs/Makefile >> >> ============================================================================== >> --- head/tests/sys/vfs/Makefile Fri Nov 17 19:10:10 2017 (r325956) >> +++ head/tests/sys/vfs/Makefile Fri Nov 17 19:25:39 2017 (r325957) >> @@ -7,6 +7,8 @@ TESTSDIR= ${TESTSBASE}/sys/vfs >> ATF_TESTS_C+= lookup_cap_dotdot >> CFLAGS.lookup_cap_dotdot.c+= -I${SRCTOP}/tests >> >> +#ATF_TESTS_SH+= lookup_test > > > This commented out line is intended? > > >> + >> TAP_TESTS_SH+= trailing_slash >> >> .include <bsd.test.mk> >> >> Added: head/tests/sys/vfs/lookup_test.sh >> >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/tests/sys/vfs/lookup_test.sh Fri Nov 17 19:25:39 2017 >> (r325957) >> @@ -0,0 +1,17 @@ >> +# $FreeBSD$ >> + >> +long_symlink_head() >> +{ >> + atf_set "descr" "Test for 1023 (PATH_MAX-1) symlink support" >> +} >> +long_symlink_body() >> +{ >> + atf_check -s exit:0 ln -s >> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa sym_long >> + # was: "stat: sym_long: stat: File name too long"; exit 1 >> + atf_check -s exit:0 -o ignore stat -L sym_long >> +} >> + >> +atf_init_test_cases() >> +{ >> + atf_add_test_case long_symlink >> +} >> > _______________________________________________ >> svn-src-h...@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org" >> > _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
