On 2018-02-12 00:28, Warner Losh wrote: > > > On Sun, Feb 11, 2018 at 10:10 PM, Rodney W. Grimes > <[email protected] <mailto:[email protected]>> > wrote: > > [ Charset UTF-8 unsupported, converting... ] > > Author: imp > > Date: Mon Feb 12 04:54:51 2018 > > New Revision: 329150 > > URL: https://svnweb.freebsd.org/changeset/base/329150 > <https://svnweb.freebsd.org/changeset/base/329150> > > > > Log: > > Install devmatch.conf, don't install usb.conf > > Doesnt this break devd and anyone depending on it? > > > I'm having problems understanding how it would break it? > > > Does usb.conf need to go in OBSOLETEFILES now? > > > Yes. It should... > > > Relnotes y? > > > Yes. It's hard to know where in the sequence of on-boarding a new > function where to put it. >
Previously Release Engineering has said they'd rather you mark a few too
many things as Relnotes: Yes, than too few. In cases like this, it might
make sense to flag the entire series of commits, so a year from now re@
stands a better chance of writing a coherent paragraph about what the
change actually is, and how it impacts the user.
> Warner
>
>
>
> > Modified:
> > head/etc/devd/Makefile
> >
> > Modified: head/etc/devd/Makefile
> >
> ==============================================================================
> > --- head/etc/devd/Makefile Mon Feb 12 04:52:25 2018 (r329149)
> > +++ head/etc/devd/Makefile Mon Feb 12 04:54:51 2018 (r329150)
> > @@ -12,13 +12,14 @@ FILES+= apple.conf
> > .if ${MK_ACPI} != "no"
> > FILES+= asus.conf
> > .endif
> > +FILES+=devmatch.conf
> ^ missing tab
>
> > .if ${MK_HYPERV} != "no"
> > FILES+= hyperv.conf
> > .endif
> > .endif
> >
> > .if ${MK_USB} != "no"
> > -FILES+= uath.conf ulpt.conf usb.conf
> > +FILES+= uath.conf ulpt.conf
> > .endif
> >
> > .if ${MK_ZFS} != "no"
>
> --
> Rod Grimes
> [email protected] <mailto:[email protected]>
>
>
--
Allan Jude
signature.asc
Description: OpenPGP digital signature
