Author: landonf
Date: Mon Feb 12 22:21:11 2018
New Revision: 329184
URL: https://svnweb.freebsd.org/changeset/base/329184

Log:
  bwn(4): Fix outstanding bug in PHY-G tssi2dbm table generation caught by
  -Wconstant-conversion, and remove now unnecessary warning suppression
  flags.

Modified:
  head/sys/conf/files
  head/sys/dev/bwn/if_bwn_phy_g.c
  head/sys/modules/bwn/Makefile

Modified: head/sys/conf/files
==============================================================================
--- head/sys/conf/files Mon Feb 12 20:51:28 2018        (r329183)
+++ head/sys/conf/files Mon Feb 12 22:21:11 2018        (r329184)
@@ -1326,15 +1326,11 @@ dev/bwi/bwiphy.c                optional bwi
 dev/bwi/bwirf.c                        optional bwi
 dev/bwi/if_bwi.c               optional bwi
 dev/bwi/if_bwi_pci.c           optional bwi pci
-# XXX Work around clang warnings, until maintainer approves fix.
-dev/bwn/if_bwn.c               optional bwn bhnd \
-       compile-with "${NORMAL_C} ${NO_WSOMETIMES_UNINITIALIZED}"
+dev/bwn/if_bwn.c               optional bwn bhnd
 dev/bwn/if_bwn_pci.c           optional bwn pci bhnd bhndb bhndb_pci
 dev/bwn/if_bwn_phy_common.c    optional bwn bhnd
-dev/bwn/if_bwn_phy_g.c         optional bwn bhnd \
-       compile-with "${NORMAL_C} ${NO_WSOMETIMES_UNINITIALIZED} 
${NO_WCONSTANT_CONVERSION}"
-dev/bwn/if_bwn_phy_lp.c                optional bwn bhnd \
-       compile-with "${NORMAL_C} ${NO_WSOMETIMES_UNINITIALIZED}"
+dev/bwn/if_bwn_phy_g.c         optional bwn bhnd
+dev/bwn/if_bwn_phy_lp.c                optional bwn bhnd
 dev/bwn/if_bwn_phy_n.c         optional bwn bhnd
 dev/bwn/if_bwn_util.c          optional bwn bhnd
 dev/cardbus/cardbus.c          optional cardbus

Modified: head/sys/dev/bwn/if_bwn_phy_g.c
==============================================================================
--- head/sys/dev/bwn/if_bwn_phy_g.c     Mon Feb 12 20:51:28 2018        
(r329183)
+++ head/sys/dev/bwn/if_bwn_phy_g.c     Mon Feb 12 22:21:11 2018        
(r329184)
@@ -216,7 +216,7 @@ do {                                                        
                \
                } while (delta >= 2);
 
                pg->pg_tssi2dbm[i] = MIN(MAX(BWN_TSSI2DBM(m1 * f, 8192), -127),
-                   128);
+                   127);
        }
 
        pg->pg_flags |= BWN_PHY_G_FLAG_TSSITABLE_ALLOC;

Modified: head/sys/modules/bwn/Makefile
==============================================================================
--- head/sys/modules/bwn/Makefile       Mon Feb 12 20:51:28 2018        
(r329183)
+++ head/sys/modules/bwn/Makefile       Mon Feb 12 22:21:11 2018        
(r329184)
@@ -38,8 +38,3 @@ SRCS.BWN_GPL_PHY+=  if_bwn_phy_n_ppr.c
 SRCS.BWN_GPL_PHY+=  if_bwn_phy_n_core.c
 
 .include <bsd.kmod.mk>
-
-# XXX Work around clang warnings, until maintainer approves fix.
-CWARNFLAGS.if_bwn.c=   ${NO_WSOMETIMES_UNINITIALIZED}
-CWARNFLAGS.if_bwn_phy_g.c=     ${NO_WSOMETIMES_UNINITIALIZED} 
${NO_WCONSTANT_CONVERSION}
-CWARNFLAGS.if_bwn_phy_lp.c=    ${NO_WSOMETIMES_UNINITIALIZED}
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to