On Wed, Feb 14, 2018 at 8:39 PM, Warner Losh <i...@bsdimp.com> wrote:
> > > On Feb 14, 2018 8:23 PM, "Eitan Adler" <ead...@freebsd.org> wrote: > > Author: eadler > Date: Thu Feb 15 03:22:53 2018 > New Revision: 329296 > URL: https://svnweb.freebsd.org/changeset/base/329296 > > Log: > devd: don't pass &fds in useless parameters to select(2) > > select(2) should be declared as restrict. In addition the only fd in > the fdset is open O_RDONLY, and it's not a socket that can provide OOB > notifications, > > Reviewed by: ian, imp, vangyzen > > > Don't put my name on this. I specifically and clearly objected to the > change anf tld yoy not to do it. > Stupid phone... I specifically objected to this change. I said not to make it because it wasn't necessary. You did it any way. Don't put "reviewed by" for that. Put "objected to but I did it anyway by: imp" Warner > > Warner > > > Modified: > head/sbin/devd/devd.cc > > Modified: head/sbin/devd/devd.cc > ============================================================ > ================== > --- head/sbin/devd/devd.cc Thu Feb 15 03:22:04 2018 (r329295) > +++ head/sbin/devd/devd.cc Thu Feb 15 03:22:53 2018 (r329296) > @@ -1021,7 +1021,7 @@ event_loop(void) > tv.tv_usec = 0; > FD_ZERO(&fds); > FD_SET(fd, &fds); > - rv = select(fd + 1, &fds, &fds, &fds, &tv); > + rv = select(fd + 1, &fds, NULL, NULL, &tv); > // No events -> we've processed all pending events > if (rv == 0) { > devdlog(LOG_DEBUG, "Calling daemon\n"); > > > _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
