On 2018-04-05 09:56, Sean Bruno wrote: > Author: sbruno > Date: Thu Apr 5 13:56:40 2018 > New Revision: 332070 > URL: https://svnweb.freebsd.org/changeset/base/332070 > > Log: > Squash error from geom by sizing ident strings to DISK_IDENT_SIZE. > > Display attribute in future error strings and differentiate g_handleattr() > error messages for ease of debugging in the future. > > "g_handleattr: md1 bio_length 24 strlen 31 -> EFAULT" > > Reported by: swills > Reviewed by: imp cem avg > Sponsored by: Limelight Networks > Differential Revision: https://reviews.freebsd.org/D14962 > > Modified: > head/sys/geom/geom_subr.c > head/sys/geom/label/g_label_disk_ident.c > head/sys/geom/raid/md_ddf.c > head/sys/geom/raid/md_intel.c > I might be missing something here, but it seems like you didn't actually change the side of
struct md_s {
...
char ident[32];
...
}
And I don't see where the destination buffer went from 24 bytes to a
larger value.
--
Allan Jude
signature.asc
Description: OpenPGP digital signature
