Author: kp
Date: Fri Apr 6 19:21:29 2018
New Revision: 332137
URL: https://svnweb.freebsd.org/changeset/base/332137
Log:
pf tests: Basic ioctl validation for DIOCIGETIFACES and DIOCXCOMMIT
Validate the DIOCIGETIFACES and DIOCXCOMMIT ioctls with invalid values.
MFC after: 1 week
Modified:
head/tests/sys/netpfil/pf/ioctl/validation.c
Modified: head/tests/sys/netpfil/pf/ioctl/validation.c
==============================================================================
--- head/tests/sys/netpfil/pf/ioctl/validation.c Fri Apr 6 19:20:45
2018 (r332136)
+++ head/tests/sys/netpfil/pf/ioctl/validation.c Fri Apr 6 19:21:29
2018 (r332137)
@@ -255,6 +255,63 @@ ATF_TC_BODY(settflags, tc)
COMMON_CLEANUP();
}
+ATF_TC_WITHOUT_HEAD(igetifaces);
+ATF_TC_BODY(igetifaces, tc)
+{
+ struct pfioc_iface io;
+ struct pfi_kif kif;
+
+ COMMON_HEAD();
+
+ bzero(&io, sizeof(io));
+ io.pfiio_flags = 0;
+ io.pfiio_buffer = &kif;
+ io.pfiio_esize = sizeof(kif);
+
+ /* Negative size */
+ io.pfiio_size = -1;
+ if (ioctl(dev, DIOCIGETIFACES, &io) == 0)
+ atf_tc_fail("request with size -1 succeeded");
+
+ /* Overflow size */
+ io.pfiio_size = 1 << 31;
+ if (ioctl(dev, DIOCIGETIFACES, &io) == 0)
+ atf_tc_fail("request with size 1 << 31 succeeded");
+
+ COMMON_CLEANUP();
+}
+
+ATF_TC_WITHOUT_HEAD(commit);
+ATF_TC_BODY(commit, tc)
+{
+ struct pfioc_trans io;
+ struct pfioc_trans_e ioe;
+
+ COMMON_HEAD();
+
+ bzero(&io, sizeof(io));
+ io.esize = sizeof(ioe);
+ io.array = &ioe;
+
+ /* Negative size */
+ io.size = -1;
+ if (ioctl(dev, DIOCXCOMMIT, &io) == 0)
+ atf_tc_fail("request with size -1 succeeded");
+
+ /* Overflow size */
+ io.size = 1 << 30;
+ if (ioctl(dev, DIOCXCOMMIT, &io) == 0)
+ atf_tc_fail("request with size 1 << 30 succeeded");
+
+ /* NULL buffer */
+ io.size = 1;
+ io.array = NULL;
+ if (ioctl(dev, DIOCXCOMMIT, &io) == 0)
+ atf_tc_fail("request with size -1 succeeded");
+
+ COMMON_CLEANUP();
+}
+
ATF_TP_ADD_TCS(tp)
{
ATF_TP_ADD_TC(tp, addtables);
@@ -263,6 +320,8 @@ ATF_TP_ADD_TCS(tp)
ATF_TP_ADD_TC(tp, gettstats);
ATF_TP_ADD_TC(tp, clrtstats);
ATF_TP_ADD_TC(tp, settflags);
+ ATF_TP_ADD_TC(tp, igetifaces);
+ ATF_TP_ADD_TC(tp, commit);
return (atf_no_error());
}
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
