On Wed, Oct 24, 2018 at 08:33:19AM +0300, Toomas Soome wrote:
> 
> 
> > On 24 Oct 2018, at 02:11, Konstantin Belousov <[email protected]> wrote:
> > 
> > Author: kib
> > Date: Tue Oct 23 23:11:38 2018
> > New Revision: 339673
> > URL: https://svnweb.freebsd.org/changeset/base/339673
> > 
> > Log:
> >  Fix stand/ build after r339671.
> > 
> >  ffs_subr.c requires calculate_crc32c() from libkern.  Unfortunately we
> >  cannot just add libkern/crc32.c to libstand because crc32.o is already
> >  compiled from contrib/zlib/crc32.c. Use the include trick to rename
> >  the source.
> > 
> >  Note that libstand also provides crc32.c which seems to be unused.
> 
> It is used by part.c, by the GPT functions. However, if we have non-optional 
> compile case for crc32, it is not hard to update part.c and drop the unused 
> instance.

My point is that static library cannot usefully contain two files with the
same name.  I believe that libstand.a provides crc32.o compiled from the
contrib/zlib location.
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to