On Fri, Nov 02, 2018 at 04:49:00PM +0200, Andriy Gapon wrote: > On 02/11/2018 16:42, Brooks Davis wrote: > > Author: brooks > > Date: Fri Nov 2 14:42:36 2018 > > New Revision: 340055 > > URL: https://svnweb.freebsd.org/changeset/base/340055 > > > > Log: > > Make vop_symlink take a const target path. > > > > This will enable callers to take const paths as part of syscall > > decleration improvements. > > > > Where doing so is easy and non-distruptive carry the const through > > implementations. In UFS the value is passed to an interface that must > > take non-const values. In ZFS, const poisoning would touch code shared > > with upstream and it's not worth adding diffs. > > zfs_vnops.c is already sufficiently different from upstream (because of quite > different VFS models), so a small difference in zfs_symlink's signature would > not be too bad.
Good to know. When I hit modifying three files I stopped. I'll keep this in the back of my mind as a possible improvement. Thanks, Brooks
signature.asc
Description: PGP signature