On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote:
> If your going to bother with a differential, and invite people to > it you should give them at least 24 hours, and preferably 72 hours > to respond to the new review. Reviews that last < 4 hours are not > code reviews. > > -- > Rod Grimes > rgri...@freebsd.org > Hi Rod, Sorry. The main reason I submitted the code review is because I do not have my src commit bit, so needed to seek approval to commit. I felt the need to commit the UPDATING entry was time sensitive, given the change it was notifying users of had already been committed. Regards, Ben -- -- From: Benjamin Woods woods...@gmail.com _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"