On Sat, Nov 10, 2018 at 12:18:13AM -0800, Eitan Adler wrote: > On Fri, 9 Nov 2018 at 10:19, Brooks Davis <bro...@freebsd.org> wrote: > > > > On Fri, Nov 09, 2018 at 06:03:01PM +0000, Brooks Davis wrote: > > > Author: brooks > > > Date: Fri Nov 9 18:03:01 2018 > > > New Revision: 340294 > > > URL: https://svnweb.freebsd.org/changeset/base/340294 > > > > > > Log: > > > Fix a number of bugs in freebsd32's capabilities.conf. > > > > > > Bugs range from failure to update after changing syscall implementaion > > > names to using the wrong name. Somewhat confusingly, the name in > > > capabilities.conf is exactly the string that appears in syscalls.master, > > > not the name with a COMPAT* prefix which is the actual function name. > > > > > > Found while making a change to use the default capabilities.conf. > > Is there any automated way to detect this in the future? Can we add > some test that detect non-existent syscalls or the like?
https://reviews.freebsd.org/D17932 fixes most of this. It wouldn't be too hard to keep track of which syscalls were emitted and check that against the set from capabilities.conf. I'll keep that in mind. -- Brooks
signature.asc
Description: PGP signature
