Author: markj
Date: Sat Nov 17 19:01:40 2018
New Revision: 340505
URL: https://svnweb.freebsd.org/changeset/base/340505

Log:
  MFC r340005:
  Remove redundant checks for a NULL lbgroup table.

Modified:
  stable/12/sys/netinet/in_pcb.c
  stable/12/sys/netinet6/in6_pcb.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/netinet/in_pcb.c
==============================================================================
--- stable/12/sys/netinet/in_pcb.c      Sat Nov 17 19:00:44 2018        
(r340504)
+++ stable/12/sys/netinet/in_pcb.c      Sat Nov 17 19:01:40 2018        
(r340505)
@@ -322,9 +322,6 @@ in_pcbinslbgrouphash(struct inpcb *inp)
        INP_WLOCK_ASSERT(inp);
        INP_HASH_WLOCK_ASSERT(pcbinfo);
 
-       if (pcbinfo->ipi_lbgrouphashbase == NULL)
-               return (0);
-
        /*
         * Don't allow jailed socket to join local group.
         */
@@ -399,9 +396,6 @@ in_pcbremlbgrouphash(struct inpcb *inp)
        INP_WLOCK_ASSERT(inp);
        INP_HASH_WLOCK_ASSERT(pcbinfo);
 
-       if (pcbinfo->ipi_lbgrouphashbase == NULL)
-               return;
-
        hdr = &pcbinfo->ipi_lbgrouphashbase[
            INP_PCBLBGROUP_PORTHASH(inp->inp_lport,
                pcbinfo->ipi_lbgrouphashmask)];
@@ -2276,13 +2270,11 @@ in_pcblookup_hash_locked(struct inpcbinfo *pcbinfo, st
        /*
         * Then look in lb group (for wildcard match).
         */
-       if (pcbinfo->ipi_lbgrouphashbase != NULL &&
-               (lookupflags & INPLOOKUP_WILDCARD)) {
+       if ((lookupflags & INPLOOKUP_WILDCARD) != 0) {
                inp = in_pcblookup_lbgroup(pcbinfo, &laddr, lport, &faddr,
                    fport, lookupflags);
-               if (inp != NULL) {
+               if (inp != NULL)
                        return (inp);
-               }
        }
 
        /*

Modified: stable/12/sys/netinet6/in6_pcb.c
==============================================================================
--- stable/12/sys/netinet6/in6_pcb.c    Sat Nov 17 19:00:44 2018        
(r340504)
+++ stable/12/sys/netinet6/in6_pcb.c    Sat Nov 17 19:01:40 2018        
(r340505)
@@ -1171,13 +1171,11 @@ in6_pcblookup_hash_locked(struct inpcbinfo *pcbinfo, s
        /*
         * Then look in lb group (for wildcard match).
         */
-       if (pcbinfo->ipi_lbgrouphashbase != NULL &&
-           (lookupflags & INPLOOKUP_WILDCARD)) {
+       if ((lookupflags & INPLOOKUP_WILDCARD) != 0) {
                inp = in6_pcblookup_lbgroup(pcbinfo, laddr, lport, faddr,
                    fport, lookupflags);
-               if (inp != NULL) {
+               if (inp != NULL)
                        return (inp);
-               }
        }
 
        /*
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to