On Thu, 14 Feb 2019 at 12:42, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote:
> > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: > > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < > > > > > Differential Review: https://reviews.freebsd.org/D19193 > > > > > > > > You sited a differential, but not give any attribution > > > > to the external source :-( > > > > > > > > > > The differential review has that information. > > > > External contributors should be recognized by having their names appear > > in the commit logs. > > We even bother to put a special line in the commit template > for this. Further it has been standard operating procedure > for at least as long as I have been back that submitters > are infact recognized in commit messages. > Yeah, Phabricator must not become a second source of truth for who actually did the work, which we had at least one case of recently. That's no good. In this case, the difference between a patch and a bug report is indistinguishable ("word X is misspelt at offset Y in file Z" is probably not really Phabricator fodder at the scale of a single instance), but it should plainly either be a Reported byline if not a Submitted one in the commit message itself. Juli. _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"