On Thu, Feb 28, 2019 at 3:44 PM Enji Cooper <yaneurab...@gmail.com> wrote: > > > > On Feb 28, 2019, at 12:48 PM, Bryan Drewery <bdrew...@freebsd.org> wrote: > > > > Author: bdrewery > > Date: Thu Feb 28 20:48:18 2019 > > New Revision: 344666 > > URL: https://svnweb.freebsd.org/changeset/base/344666 > > > > Log: > > bsd.nls.mk isn't optional. > > > > It is protected by MK_NLS. If it should really be optional then > > it needs to be documented as such in share/mk/bsd.README and > > .sinclude used where needed. > > > > This fixes a regression from r335011. > > > > PR: 232527 > > Submitted by: jar...@downtools.com.au > > Reported by: ktulla...@gmail.com > > MFC after: 3 days > > Should bsd.{lib,prog}.mk instead be taught to ignore errors when > including this file? > Thanks! > -Enji
If we actually conditionally installed it, sure- it was only removed because of r335011, so it would go through an install/remove dance between installworld and delete-old on WITHOUT_NLS systems. If we're going to make it conditional on MK_NLS, it needs to actually be conditional on MK_NLS the proper way along with an s/.include/.sinclude/. _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
