Author: rrs
Date: Wed Apr 10 18:58:11 2019
New Revision: 346094
URL: https://svnweb.freebsd.org/changeset/base/346094

Log:
  Fix a small bug in the tcp_log_id where the bucket
  was unlocked and yet the bucket-unlock flag was not
  changed to false. This can cause a panic if INVARIANTS
  is on and we go through the right path (though rare).
  This fixes the correct bug :)
  
  Reported by:  syzbot+179a1ad49f3c4c215...@syzkaller.appspotmail.com
  Reviewed by:  tuexen@

Modified:
  head/sys/netinet/tcp_log_buf.c

Modified: head/sys/netinet/tcp_log_buf.c
==============================================================================
--- head/sys/netinet/tcp_log_buf.c      Wed Apr 10 18:17:27 2019        
(r346093)
+++ head/sys/netinet/tcp_log_buf.c      Wed Apr 10 18:58:11 2019        
(r346094)
@@ -752,6 +752,7 @@ refind:
                        RECHECK_INP();
                        if (tp->t_lib != NULL) {
                                TCPID_BUCKET_UNLOCK(tlb);
+                               bucket_locked = false;
                                tlb = NULL;
                                goto restart;
                        }
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to