Author: emaste
Date: Tue May 21 21:27:14 2019
New Revision: 348069
URL: https://svnweb.freebsd.org/changeset/base/348069
Log:
bootpd: avoid the same error indication for different issues
There were several (apparently) copy-pasted NEED validation macros,
leading to the same error string for different issues. Change the
YP and NTP tags so they are distinct.
PR: 30863
Submitted by: Dan Lukes <d...@obluda.cz>
Reviewed by: markj
MFC after: 1 week
Event: Waterloo Hackathon 2019
Modified:
head/libexec/bootpd/dovend.c
Modified: head/libexec/bootpd/dovend.c
==============================================================================
--- head/libexec/bootpd/dovend.c Tue May 21 21:26:18 2019
(r348068)
+++ head/libexec/bootpd/dovend.c Tue May 21 21:27:14 2019
(r348069)
@@ -147,7 +147,7 @@ dovend_rfc1497(hp, buf, len)
if (insert_ip(TAG_NIS_SERVER,
hp->nis_server,
&vp, &bytesleft))
- NEED(8, "ds");
+ NEED(8, "ys");
}
if (hp->flags.nis_domain) {
/*
@@ -155,7 +155,7 @@ dovend_rfc1497(hp, buf, len)
* TAG_NIS_DOMAIN and length.
*/
len = strlen(hp->nis_domain->string);
- NEED((len + 2), "dn");
+ NEED((len + 2), "yn");
*vp++ = TAG_NIS_DOMAIN;
*vp++ = (byte) (len & 0xFF);
bcopy(hp->nis_domain->string, vp, len);
@@ -187,7 +187,7 @@ dovend_rfc1497(hp, buf, len)
if (insert_ip(TAG_NTP_SERVER,
hp->ntp_server,
&vp, &bytesleft))
- NEED(8, "ts");
+ NEED(8, "nt");
}
/*
* I wonder: If the hostname were "promoted" into the BOOTP
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
