On Fri, Sep 13, 2019 at 5:04 PM Chuck Silvers <c...@freebsd.org> wrote:

> Author: chs
> Date: Fri Sep 13 23:03:56 2019
> New Revision: 352312
> URL: https://svnweb.freebsd.org/changeset/base/352312
>
> Log:
>   Add a "count_until_fail" option to gnop, which says to start failing
>   I/O requests after the given number have been allowed though.
>
>   Approved by:    imp (mentor)
>   Reviewed by:    rpokala kib 0mp mckusick
>   Sponsored by:   Netflix
>   Differential Revision:  https://reviews.freebsd.org/D21593
>
> Modified:
>   head/lib/geom/nop/geom_nop.c
>   head/lib/geom/nop/gnop.8
>   head/sys/geom/nop/g_nop.c
>   head/sys/geom/nop/g_nop.h
>

This patch introduces a backwards-compatibility bug.  On a system with a
post-352312 kernel but a pre-352312 userland, the gnop command will always
fail with the error "gnop: Missing count_until_fail argument".
-Alan
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to