On 2019-10-08 14:48, Bjoern A. Zeeb wrote:
On 7 Oct 2019, at 14:15, Hans Petter Selasky wrote:
Author: hselasky
Date: Mon Oct 7 14:15:41 2019
New Revision: 353274
URL: https://svnweb.freebsd.org/changeset/base/353274
Log:
Factor out VNET shutdown check into an own vnet structure field.
Remove the now obsolete vnet_state field. This greatly simplifies the
detection of VNET shutdown and avoids code duplication.
I think I tried to say that the vnet_state is extremely helpful for
debugging as you know where each of the stacks is during
initialisation/shutdown, especially with loadable modules and that it
should stay and I cannot remember that I removed it in the patch that I
suggested.
I didn’t re-used a field but extended the structure. What you did means
you cannot MFC this easily. Also it means that all previous vnet
consumers got invalidated and the VNET_MAGIC_N should have been bumped
and all modules need a re-compile.
OK I can fix that, but should VNET_MAGIC_N be bumped when adding the new
vnet_shutdown boolean to this structure?
--HPS
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"
