Author: eugen
Date: Thu Jan 16 08:11:45 2020
New Revision: 356778
URL: https://svnweb.freebsd.org/changeset/base/356778

Log:
  MFC r356551: arp(8): avoid segfaulting due to out-of-bounds memory access
  
  Fix obvious mistake that sometimes results in reading memory
  past end of an array.
  
  PR:           242784

Modified:
  stable/12/usr.sbin/arp/arp.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/usr.sbin/arp/arp.c
==============================================================================
--- stable/12/usr.sbin/arp/arp.c        Thu Jan 16 07:02:09 2020        
(r356777)
+++ stable/12/usr.sbin/arp/arp.c        Thu Jan 16 08:11:45 2020        
(r356778)
@@ -627,8 +627,7 @@ print_entry(struct sockaddr_dl *sdl,
        } else
                xo_emit("{d:/(incomplete)}{en:incomplete/true}");
 
-       for (p = ifnameindex; p && ifnameindex->if_index &&
-           ifnameindex->if_name; p++) {
+       for (p = ifnameindex; p && p->if_index && p->if_name; p++) {
                if (p->if_index == sdl->sdl_index) {
                        xo_emit(" on {:interface/%s}", p->if_name);
                        break;
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to