Author: tuexen
Date: Tue Feb  4 12:34:16 2020
New Revision: 357500
URL: https://svnweb.freebsd.org/changeset/base/357500

Log:
  Improve numbering of debug information.
  
  Submitted by:         Taylor Brandstetter
  MFC after:            1 week

Modified:
  head/sys/netinet/sctp_constants.h
  head/sys/netinet/sctp_indata.c

Modified: head/sys/netinet/sctp_constants.h
==============================================================================
--- head/sys/netinet/sctp_constants.h   Tue Feb  4 12:33:00 2020        
(r357499)
+++ head/sys/netinet/sctp_constants.h   Tue Feb  4 12:34:16 2020        
(r357500)
@@ -807,7 +807,7 @@ __FBSDID("$FreeBSD$");
 #define SCTP_LOC_33 0x00000021
 #define SCTP_LOC_34 0x00000022
 #define SCTP_LOC_35 0x00000023
-
+#define SCTP_LOC_36 0x00000024
 
 /* Free assoc codes */
 #define SCTP_NORMAL_PROC      0

Modified: head/sys/netinet/sctp_indata.c
==============================================================================
--- head/sys/netinet/sctp_indata.c      Tue Feb  4 12:33:00 2020        
(r357499)
+++ head/sys/netinet/sctp_indata.c      Tue Feb  4 12:34:16 2020        
(r357500)
@@ -1754,7 +1754,7 @@ sctp_process_a_data_chunk(struct sctp_tcb *stcb, struc
                 * Need to send an abort since we had a empty data chunk.
                 */
                op_err = sctp_generate_no_user_data_cause(tsn);
-               stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_14;
+               stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_15;
                sctp_abort_an_association(stcb->sctp_ep, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                *abort_flag = 1;
                return (0);
@@ -1892,7 +1892,7 @@ sctp_process_a_data_chunk(struct sctp_tcb *stcb, struc
                                snprintf(msg, sizeof(msg), "Reassembly problem 
(MID=%8.8x)", mid);
                err_out:
                                op_err = 
sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, msg);
-                               stcb->sctp_ep->last_abort_code = 
SCTP_FROM_SCTP_INDATA + SCTP_LOC_15;
+                               stcb->sctp_ep->last_abort_code = 
SCTP_FROM_SCTP_INDATA + SCTP_LOC_16;
                                sctp_abort_an_association(stcb->sctp_ep, stcb, 
op_err, SCTP_SO_NOT_LOCKED);
                                *abort_flag = 1;
                                return (0);
@@ -2041,7 +2041,7 @@ sctp_process_a_data_chunk(struct sctp_tcb *stcb, struc
                            (uint16_t)mid);
                }
                op_err = sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, 
msg);
-               stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_16;
+               stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_17;
                sctp_abort_an_association(stcb->sctp_ep, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                *abort_flag = 1;
                return (0);
@@ -2613,7 +2613,7 @@ sctp_sack_check(struct sctp_tcb *stcb, int was_a_gap)
                if (SCTP_OS_TIMER_PENDING(&stcb->asoc.dack_timer.timer)) {
                        sctp_timer_stop(SCTP_TIMER_TYPE_RECV,
                            stcb->sctp_ep, stcb, NULL,
-                           SCTP_FROM_SCTP_INDATA + SCTP_LOC_17);
+                           SCTP_FROM_SCTP_INDATA + SCTP_LOC_18);
                }
                sctp_send_shutdown(stcb,
                    ((stcb->asoc.alternate) ? stcb->asoc.alternate : 
stcb->asoc.primary_destination));
@@ -2766,7 +2766,7 @@ sctp_process_data(struct mbuf **mm, int iphlen, int *o
 
                        snprintf(msg, sizeof(msg), "%s", "I-DATA chunk received 
when DATA was negotiated");
                        op_err = 
sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, msg);
-                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_18;
+                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_20;
                        sctp_abort_an_association(inp, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                        return (2);
                }
@@ -2777,7 +2777,7 @@ sctp_process_data(struct mbuf **mm, int iphlen, int *o
 
                        snprintf(msg, sizeof(msg), "%s", "DATA chunk received 
when I-DATA was negotiated");
                        op_err = 
sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, msg);
-                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_19;
+                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_21;
                        sctp_abort_an_association(inp, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                        return (2);
                }
@@ -2802,7 +2802,7 @@ sctp_process_data(struct mbuf **mm, int iphlen, int *o
                                    ch->chunk_type == SCTP_DATA ? "DATA" : 
"I-DATA",
                                    chk_length);
                                op_err = 
sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, msg);
-                               stcb->sctp_ep->last_abort_code = 
SCTP_FROM_SCTP_INDATA + SCTP_LOC_20;
+                               stcb->sctp_ep->last_abort_code = 
SCTP_FROM_SCTP_INDATA + SCTP_LOC_22;
                                sctp_abort_an_association(inp, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                                return (2);
                        }
@@ -2891,7 +2891,7 @@ sctp_process_data(struct mbuf **mm, int iphlen, int *o
                                        snprintf(msg, sizeof(msg), "Chunk of 
length %u",
                                            chk_length);
                                        op_err = 
sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, msg);
-                                       stcb->sctp_ep->last_abort_code = 
SCTP_FROM_SCTP_INDATA + SCTP_LOC_20;
+                                       stcb->sctp_ep->last_abort_code = 
SCTP_FROM_SCTP_INDATA + SCTP_LOC_23;
                                        sctp_abort_an_association(inp, stcb, 
op_err, SCTP_SO_NOT_LOCKED);
                                        return (2);
                                }
@@ -4041,7 +4041,7 @@ sctp_express_handle_sack(struct sctp_tcb *stcb, uint32
                snprintf(msg, sizeof(msg), "Cum ack %8.8x greater or equal than 
TSN %8.8x",
                    cumack, send_s);
                op_err = sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, 
msg);
-               stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_21;
+               stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_24;
                sctp_abort_an_association(stcb->sctp_ep, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                return;
        }
@@ -4237,7 +4237,7 @@ sctp_express_handle_sack(struct sctp_tcb *stcb, uint32
                                        net->dest_state &= ~SCTP_ADDR_PF;
                                        
sctp_timer_stop(SCTP_TIMER_TYPE_HEARTBEAT,
                                            stcb->sctp_ep, stcb, net,
-                                           SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_22);
+                                           SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_25);
                                        
sctp_timer_start(SCTP_TIMER_TYPE_HEARTBEAT, stcb->sctp_ep, stcb, net);
                                        
asoc->cc_functions.sctp_cwnd_update_exit_pf(stcb, net);
                                        /* Done with this net */
@@ -4315,7 +4315,7 @@ again:
                        } else if 
(SCTP_OS_TIMER_PENDING(&net->rxt_timer.timer)) {
                                sctp_timer_stop(SCTP_TIMER_TYPE_SEND, 
stcb->sctp_ep,
                                    stcb, net,
-                                   SCTP_FROM_SCTP_INDATA + SCTP_LOC_23);
+                                   SCTP_FROM_SCTP_INDATA + SCTP_LOC_26);
                        }
                }
        }
@@ -4368,7 +4368,7 @@ again:
                        *abort_now = 1;
                        /* XXX */
                        op_err = 
sctp_generate_cause(SCTP_CAUSE_USER_INITIATED_ABT, "");
-                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_24;
+                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_27;
                        sctp_abort_an_association(stcb->sctp_ep, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                        return;
                }
@@ -4578,7 +4578,7 @@ hopeless_peer:
                snprintf(msg, sizeof(msg), "Cum ack %8.8x greater or equal than 
TSN %8.8x",
                    cum_ack, send_s);
                op_err = sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, 
msg);
-               stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_25;
+               stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_28;
                sctp_abort_an_association(stcb->sctp_ep, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                return;
        }
@@ -4610,7 +4610,7 @@ hopeless_peer:
                /* stop any timers */
                TAILQ_FOREACH(net, &asoc->nets, sctp_next) {
                        sctp_timer_stop(SCTP_TIMER_TYPE_SEND, stcb->sctp_ep,
-                           stcb, net, SCTP_FROM_SCTP_INDATA + SCTP_LOC_26);
+                           stcb, net, SCTP_FROM_SCTP_INDATA + SCTP_LOC_29);
                        net->partial_bytes_acked = 0;
                        net->flight_size = 0;
                }
@@ -4810,14 +4810,14 @@ hopeless_peer:
                        if (net->new_pseudo_cumack)
                                sctp_timer_stop(SCTP_TIMER_TYPE_SEND, 
stcb->sctp_ep,
                                    stcb, net,
-                                   SCTP_FROM_SCTP_INDATA + SCTP_LOC_27);
+                                   SCTP_FROM_SCTP_INDATA + SCTP_LOC_30);
 
                }
        } else {
                if (accum_moved) {
                        TAILQ_FOREACH(net, &asoc->nets, sctp_next) {
                                sctp_timer_stop(SCTP_TIMER_TYPE_SEND, 
stcb->sctp_ep,
-                                   stcb, net, SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_28);
+                                   stcb, net, SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_31);
                        }
                }
        }
@@ -5000,7 +5000,7 @@ hopeless_peer:
                                        net->dest_state &= ~SCTP_ADDR_PF;
                                        
sctp_timer_stop(SCTP_TIMER_TYPE_HEARTBEAT,
                                            stcb->sctp_ep, stcb, net,
-                                           SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_29);
+                                           SCTP_FROM_SCTP_INDATA + 
SCTP_LOC_32);
                                        
sctp_timer_start(SCTP_TIMER_TYPE_HEARTBEAT, stcb->sctp_ep, stcb, net);
                                        
asoc->cc_functions.sctp_cwnd_update_exit_pf(stcb, net);
                                        /* Done with this net */
@@ -5025,7 +5025,7 @@ hopeless_peer:
                        /* stop all timers */
                        sctp_timer_stop(SCTP_TIMER_TYPE_SEND, stcb->sctp_ep,
                            stcb, net,
-                           SCTP_FROM_SCTP_INDATA + SCTP_LOC_30);
+                           SCTP_FROM_SCTP_INDATA + SCTP_LOC_33);
                        net->flight_size = 0;
                        net->partial_bytes_acked = 0;
                }
@@ -5063,7 +5063,7 @@ hopeless_peer:
                        *abort_now = 1;
                        /* XXX */
                        op_err = 
sctp_generate_cause(SCTP_CAUSE_USER_INITIATED_ABT, "");
-                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_24;
+                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_34;
                        sctp_abort_an_association(stcb->sctp_ep, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                        return;
                }
@@ -5212,7 +5212,7 @@ again:
                        } else if 
(SCTP_OS_TIMER_PENDING(&net->rxt_timer.timer)) {
                                sctp_timer_stop(SCTP_TIMER_TYPE_SEND, 
stcb->sctp_ep,
                                    stcb, net,
-                                   SCTP_FROM_SCTP_INDATA + SCTP_LOC_32);
+                                   SCTP_FROM_SCTP_INDATA + SCTP_LOC_35);
                        }
                }
        }
@@ -5618,7 +5618,7 @@ sctp_handle_forward_tsn(struct sctp_tcb *stcb,
                            "New cum ack %8.8x too high, highest TSN %8.8x",
                            new_cum_tsn, asoc->highest_tsn_inside_map);
                        op_err = 
sctp_generate_cause(SCTP_CAUSE_PROTOCOL_VIOLATION, msg);
-                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_33;
+                       stcb->sctp_ep->last_abort_code = SCTP_FROM_SCTP_INDATA 
+ SCTP_LOC_36;
                        sctp_abort_an_association(stcb->sctp_ep, stcb, op_err, 
SCTP_SO_NOT_LOCKED);
                        return;
                }
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to