On Fri, Jan 17, 2020 at 01:15:55AM +0000, Warner Losh wrote: > Author: imp > Date: Fri Jan 17 01:15:55 2020 > New Revision: 356818 > URL: https://svnweb.freebsd.org/changeset/base/356818 > > Log: > Pass BIO_SPEEDUP through all the geom layers > > While some geom layers pass unknown commands down, not all do. For the ones > that > don't, pass BIO_SPEEDUP down to the providers that constittue the geom, as > applicable. No changes to vinum or virstor because I was unsure how to add > this > support, and I'm also unsure how to test these. gvinum doesn't implement > BIO_FLUSH either, so it may just be poorly maintained. gvirstor is for > testing > and not supportig BIO_SPEEDUP is fine. > > Reviewed by: chs > Differential Revision: https://reviews.freebsd.org/D23183
Hi Warner, BIO_SPEEDUP triggers an assertion failure in virtblk, as found by syzkaller. I'm not sure how best to handle it - I don't think there's anything the driver can really do with BIO_SPEEDUP, so it could be dropped, but maybe it's unexpected that it's made it to this layer in the first place. http://syzkaller.backtrace.io:8080/file?name=crashes%2f1e84321d4576307b788b7c3e4526facc7d10a46c%2freport0 _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "[email protected]"
