Author: emaste
Date: Sun Mar  8 23:20:24 2020
New Revision: 358791
URL: https://svnweb.freebsd.org/changeset/base/358791

Log:
  MFC r350294: pf: zero output buffer in pfioctl
  
  Avoid potential structure padding leak.
  
  Reported by:  Vlad Tsyrklevich <[email protected]>
  Security:     Potential kernel memory disclosure
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/12/sys/netpfil/pf/pf_ioctl.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/netpfil/pf/pf_ioctl.c
==============================================================================
--- stable/12/sys/netpfil/pf/pf_ioctl.c Sun Mar  8 23:19:09 2020        
(r358790)
+++ stable/12/sys/netpfil/pf/pf_ioctl.c Sun Mar  8 23:20:24 2020        
(r358791)
@@ -2169,7 +2169,7 @@ relock_DIOCKILLSTATES:
                        break;
                }
 
-               p = pstore = malloc(ps->ps_len, M_TEMP, M_WAITOK);
+               p = pstore = malloc(ps->ps_len, M_TEMP, M_WAITOK | M_ZERO);
                nr = 0;
 
                for (i = 0; i <= pf_hashmask; i++) {
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to