On Tue, Apr 14, 2020 at 03:08:24PM -0700, Conrad Meyer wrote: > Brooks, > > On Tue, Apr 14, 2020 at 13:31 Brooks Davis <bro...@freebsd.org> wrote: > > > Author: brooks > > Date: Tue Apr 14 20:30:48 2020 > > New Revision: 359937 > > URL: https://svnweb.freebsd.org/changeset/base/359937 > > > > Log: > > Centralize compatability translation macros. > > > > Copy the CP, PTRIN, etc macros from freebsd32.h into a sys/abi_compat.h > > and replace existing definitation with includes where required. This > > eliminates duplicate code and allows Linux and FreeBSD compatability > > headers to be included in the same files. > > > > Input from: cem, jhb > > > You dismissed my input, so I don???t think there???s a good reason to suggest > I > was involved with the revision.
I apologize. I did make some (admittedly trivial) changes in response to your feedback and thought it was worth a mention. Your other proposed suggestions do seem worth exploring, but they were an enormous expansion of scope from a tiny bit of code consolidation to touching a large portion of macro sites. -- Brooks
signature.asc
Description: PGP signature
