On 2010-06-16, at 11:03, Andrew Turner wrote: > On Sun, 13 Jun 2010 13:08:23 +0000 (UTC) > Rafal Jaworowski <r...@freebsd.org> wrote: > >> Author: raj >> Date: Sun Jun 13 13:08:23 2010 >> New Revision: 209129 >> URL: http://svn.freebsd.org/changeset/base/209129 >> >> Log: >> Improve style. >> >> Modified: >> head/sys/arm/arm/nexus.c >> >> Modified: head/sys/arm/arm/nexus.c >> ============================================================================== >> --- head/sys/arm/arm/nexus.c Sun Jun 13 13:02:43 2010 >> (r209128) +++ head/sys/arm/arm/nexus.c Sun Jun 13 13:08:23 >> 2010 (r209129) @@ -107,6 +107,7 @@ static devclass_t >> nexus_devclass; static int >> nexus_probe(device_t dev) >> { >> + >> device_quiet(dev); /* suppress attach message for >> neatness */ >> mem_rman.rm_start = 0; >> @@ -116,7 +117,7 @@ nexus_probe(device_t dev) >> if (rman_init(&mem_rman) || rman_manage_region(&mem_rman, 0, >> ~0u)) panic("nexus_probe mem_rman"); >> >> - return (0); >> + return (BUS_PROBE_DEFAULT); > Changing the return value of nexus_probe from 0 to BUS_PROBE_DEFAULT > causes the following panic for me when the s3c24x0 driver calls > rman_init. The attached patch fixes it by moving the call to rman_init > from nexus_probe to nexus_attach.
Thanks (and sorry for the breakage -- it wasn't seen on FDT-enabled platforms as they use their own rman(s)..), should be fixed in r209232. Rafal _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
