On Wednesday, January 19, 2011 12:56:35 am Peter Jeremy wrote: > On 2011-Jan-18 15:23:16 +0000, John Baldwin <[email protected]> wrote: > >Log: > > Remove some always-true comparisons. > ... > >--- head/sys/dev/cs/if_cs.c Tue Jan 18 14:58:44 2011 (r217537) > >+++ head/sys/dev/cs/if_cs.c Tue Jan 18 15:23:16 2011 (r217538) > >@@ -364,7 +364,7 @@ cs_cs89x0_probe(device_t dev) > > > > if (!error && !(sc->flags & CS_NO_IRQ)) { > > if (chip_type == CS8900) { > >- if (irq >= 0 || irq < 16) > >+ if (irq < 16) > > irq = cs8900_irq2eeint[irq]; > > else > > irq = 255; > > Irrespective of the signedness or otherwise of "irq", I'm fairly > certain that '||' should have been '&&' before.
Agreed. -- John Baldwin _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "[email protected]"
