On Fri, Mar 11, 2011 at 07:27:31PM +0000, Andriy Gapon wrote: > Author: avg > Date: Fri Mar 11 19:27:31 2011 > New Revision: 219526 > URL: http://svn.freebsd.org/changeset/base/219526 > > Log: > use even larger stack size for ZFS txg_sync_thread > > While the stack size was larger than the default stack size on i386, it > was smaller than the default stack size on amd64 and apparently that > wasn't enough. So, bump the size to 4 pages. Upcoming ZFSv28 code uses > 8 pages for this stack size. > > This is a direct commit to stable/8. > > PR: kern/154681 > Discussed with: pjd > > Modified: > stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c > > Modified: stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c > ============================================================================== > --- stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Fri Mar > 11 19:21:42 2011 (r219525) > +++ stable/8/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Fri Mar > 11 19:27:31 2011 (r219526) > @@ -146,7 +146,7 @@ txg_sync_start(dsl_pool_t *dp) > * 32-bit x86. This is due in part to nested pools and > * scrub_visitbp() recursion. > */ > - tx->tx_sync_thread = thread_create(NULL, 12<<10, txg_sync_thread, > + tx->tx_sync_thread = thread_create(NULL, 16<<10, txg_sync_thread, > dp, 0, &p0, TS_RUN, minclsyspri); > > mutex_exit(&tx->tx_sync_lock); What about architectures where PAGE_SIZE != 4096 ? We have ptoa() macro.
pgp6w5vokKhgQ.pgp
Description: PGP signature
