-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/20/11 23:23, Andrey V. Elsukov wrote: > On 21.06.2011 10:04, Xin LI wrote: >>>> Mod the offset padding by alignment. Without this change we may >>>> pad too much when underlying GEOM object have a zero stripesize. >> >>> No. In any way offset value could not be greater than mediasize. >> I don't think this changeset do anything with mediasize? > > I did mean that it could not pad too much. When stripesize is zero the > stripeoffset points to real offset from the beginning of device. > In case when we have nested partitioning schemes like MBR + BSD, > stripeoffset of BSD slice could help align partition to the device.
Yes agreed. >>> And it do nothing when alignment value is 1. >> >> No, an alignment value of 1 makes offset = 0, which is the intended >> behavior. >> >> Or did I misunderstood the code? > > The problem that Kris reported was not here. > I think this change is just for the reassurance. Well, I think semantically the offset variable expects a value that represents in-stripe offset rather than the real (against the media) offset that GEOM returns. I'll defer the merge until your change have been merged. Cheers, - -- Xin LI <delp...@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBCAAGBQJOAFbgAAoJEATO+BI/yjfBNPkH/1HEUxWDuUFoO+4r8FGuTyek 8oFYip67HztN5l8CWiOP61utGPyMLcyk5hS6CwkvAiHaChQeGp75Sp/16D0xkyiT qcJOZIUjtTRvkABrLD/M5vLM5nU3cg80quhPmAjXuPytJFBsy7QdP1cjXK7ql0sB bCXMhqWR8oAbQ5rch8BkFlmRQmHEWFVlR2puxUoBi+YrUEKAiv83ghC9UE4H6NT8 trA+UYr+px2AC+opU0yijdscevdVPdJi6mo08EFqbC6ABzIwTR2Ky2LLhdGrmuk+ impuJz4r44LsKvAxOqFn9bZoBLRTxHMkSju4R8kaAfxT3dehTOK2RViI3FaH7Ko= =jRrp -----END PGP SIGNATURE----- _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
