Thu, Jan 19, 2012 at 11:27:59AM -0600, Brooks Davis wrote: > On Fri, Jan 13, 2012 at 11:21:48AM +0400, Eygene Ryabinkin wrote: > > The related topic: in the process of grepping for dhclient within > > /etc, I had found that /etc/netstart still wants to invoke it. But it > > will do a lone '/etc/rc.d/dhclient quietstart' and this will never > > be useful in the current state of dhclient: it will refuse to process > > any commands without the interface being specified. And since we > > have the invocation of /etc/rc.d/netif just two lines above, I think > > that it will be good to remove call to dhclient from /etc/netstart. [...] > > Removing it from /etc/netstart is the right thing to do.
Will do it today. > Arguably it should be moved to /libexec since it's not an rc.d > script and simply uses the framework because it had similar needs Well, I fear that some user scripts may rely on the dhclient path to be /etc/rc.d/dhclient, so such a change could lead to the POLA violation. So, all pros and cons of such a change should be carefully weighted. What is the gain from moving it to /libexec apart from avoiding pollution of /etc/rc.d by non-rc.d scripts? It is a good thing to have for the clear design, but having dhclient in /etc/rc.d has no effect on the boot process, since it is marked 'nostart' and it allows people to use 'service dhclient restart $if' without hacking the service to still allow to use this command. We can, of course, move it to /libexec/rc.d/ and add this path to the local_startup, but I doubt that this approach will give any real gain, though I can be missing some important points. -- Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
pgp0pzx4Z0YZo.pgp
Description: PGP signature
