Author: kib
Date: Wed Feb  8 15:19:49 2012
New Revision: 231205
URL: http://svn.freebsd.org/changeset/base/231205

Log:
  MFC r230553:
  When doing vflush(WRITECLOSE), clean vnode pages.
  
  Unmounts do vfs_msync() before calling VFS_UNMOUNT(), but there is
  still a race allowing a process to dirty pages after msync
  finished. Remounts rw->ro just left dirty pages in system.

Modified:
  stable/8/sys/kern/vfs_subr.c
Directory Properties:
  stable/8/sys/   (props changed)

Modified: stable/8/sys/kern/vfs_subr.c
==============================================================================
--- stable/8/sys/kern/vfs_subr.c        Wed Feb  8 15:07:19 2012        
(r231204)
+++ stable/8/sys/kern/vfs_subr.c        Wed Feb  8 15:19:49 2012        
(r231205)
@@ -2501,6 +2501,18 @@ loop:
                 * vnodes open for writing.
                 */
                if (flags & WRITECLOSE) {
+                       if (vp->v_object != NULL) {
+                               VM_OBJECT_LOCK(vp->v_object);
+                               vm_object_page_clean(vp->v_object, 0, 0, 0);
+                               VM_OBJECT_UNLOCK(vp->v_object);
+                       }
+                       error = VOP_FSYNC(vp, MNT_WAIT, td);
+                       if (error != 0) {
+                               VOP_UNLOCK(vp, 0);
+                               vdrop(vp);
+                               MNT_VNODE_FOREACH_ABORT(mp, mvp);
+                               return (error);
+                       }
                        error = VOP_GETATTR(vp, &vattr, td->td_ucred);
                        VI_LOCK(vp);
 
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to