On Mon, Mar 19, 2012 at 01:27:55AM +0000, Eitan Adler wrote: > Author: eadler > Date: Mon Mar 19 01:27:55 2012 > New Revision: 233147 > URL: http://svn.freebsd.org/changeset/base/233147 > > Log: > MFC r232503: > POSIX mandates that swab do nothing when len < 0 > > PR: 140690 > Approved by: cperciva > > Modified: stable/8/lib/libc/string/swab.c > ============================================================================== > --- stable/8/lib/libc/string/swab.c Mon Mar 19 01:27:30 2012 > (r233146) > +++ stable/8/lib/libc/string/swab.c Mon Mar 19 01:27:55 2012 > (r233147) > @@ -45,6 +45,8 @@ swab(const void * __restrict from, void > int n; > char *fp, *tp; > > + if (len <= 0) > + return;
Does this not test to see if it is also equal to 0(zero) ? If I understand the above statement "POSIX mandates that swab do nothing when len < 0" then the above code should be exactly that ... and not testing whether it is equal to zero... > n = len >> 1; > fp = (char *)from; > tp = (char *)to; > _______________________________________________ > svn-src-stabl...@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-stable-8 > To unsubscribe, send any mail to "svn-src-stable-8-unsubscr...@freebsd.org" -- ;s =;
pgp93LJzZO0Lr.pgp
Description: PGP signature
