Author: marius
Date: Sat Jun  2 18:57:13 2012
New Revision: 236468
URL: http://svn.freebsd.org/changeset/base/236468

Log:
  MFC: r236061
  
  - When creating the DMA tag for user data, don't ask for more segments
    than required for handling MAXPHYS and report the resulting maximum
    I/O size to CAM instead of implicitly limiting it to DFLTPHYS.
  - Move the variables of sym_action2() out of nested scope as required
    by style(9) and remove extraneous curly braces.
  - Replace a magic value for PCIR_COMMAND with the appropriate macro.
  - Use DEVMETHOD_END.
  - Use NULL instead of 0 for pointers.
  
  Tested with a HBA donated by wilko.

Added:
  stable/9/sys/arm/at91/board_ethernut5.c
     - copied unchanged from r235348, head/sys/arm/at91/board_ethernut5.c
  stable/9/sys/arm/at91/std.ethernut5
     - copied unchanged from r235348, head/sys/arm/at91/std.ethernut5
  stable/9/sys/arm/conf/ETHERNUT5
     - copied unchanged from r235348, head/sys/arm/conf/ETHERNUT5
  stable/9/sys/arm/conf/ETHERNUT5.hints
     - copied unchanged from r235348, head/sys/arm/conf/ETHERNUT5.hints
Modified:
  stable/9/sys/arm/at91/files.at91sam9
  stable/9/sys/dev/sym/sym_conf.h
  stable/9/sys/dev/sym/sym_hipd.c
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/amd64/include/xen/   (props changed)
  stable/9/sys/boot/   (props changed)
  stable/9/sys/boot/i386/efi/   (props changed)
  stable/9/sys/boot/ia64/efi/   (props changed)
  stable/9/sys/boot/ia64/ski/   (props changed)
  stable/9/sys/boot/powerpc/boot1.chrp/   (props changed)
  stable/9/sys/boot/powerpc/ofw/   (props changed)
  stable/9/sys/cddl/contrib/opensolaris/   (props changed)
  stable/9/sys/conf/   (props changed)
  stable/9/sys/contrib/dev/acpica/   (props changed)
  stable/9/sys/contrib/octeon-sdk/   (props changed)
  stable/9/sys/contrib/pf/   (props changed)
  stable/9/sys/contrib/x86emu/   (props changed)
  stable/9/sys/dev/   (props changed)
  stable/9/sys/dev/e1000/   (props changed)
  stable/9/sys/dev/ixgbe/   (props changed)
  stable/9/sys/fs/   (props changed)
  stable/9/sys/fs/ntfs/   (props changed)
  stable/9/sys/modules/   (props changed)

Copied: stable/9/sys/arm/at91/board_ethernut5.c (from r235348, 
head/sys/arm/at91/board_ethernut5.c)
==============================================================================
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ stable/9/sys/arm/at91/board_ethernut5.c     Sat Jun  2 18:57:13 2012        
(r236468, copy of r235348, head/sys/arm/at91/board_ethernut5.c)
@@ -0,0 +1,146 @@
+/*-
+ * Copyright (c) 2012 Marius Strobl <[email protected]>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ */
+
+/*
+ * Ethernut 5 board support
+ */
+
+#include <sys/cdefs.h>
+__FBSDID("$FreeBSD$");
+
+#include <sys/param.h>
+#include <sys/systm.h>
+#include <arm/at91/at91_pioreg.h>
+#include <arm/at91/at91_piovar.h>
+#include <arm/at91/at91board.h>
+#include <arm/at91/at91sam9260reg.h>
+
+long
+board_init(void)
+{
+
+       /*
+        * DBGU
+        */
+       /* DRXD */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB14, 0);
+       /* DTXD */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB15, 1);
+
+       /*
+        * EMAC
+        */
+       /* ETX0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA12, 0);
+       /* ETX1 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA13, 0);
+       /* ERX0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA14, 0);
+       /* ERX1 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA15, 0);
+       /* ETXEN */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA16, 0);
+       /* ERXDV */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA17, 0);
+       /* ERXER */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA18, 0);
+       /* ETXCK */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA19, 0);
+       /* EMDC */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA20, 0);
+       /* EMDIO */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA21, 0);
+
+       /*
+        * MMC
+        */
+       /* MCDA0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA6, 1);
+       /* MCCDA */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA7, 1);
+       /* MCCK */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA8, 1);
+       /* MCDA1 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA9, 1);
+       /* MCDA2 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA10, 1);
+       /* MCDA3 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA11, 1);
+
+       /*
+        * SPI0
+        */
+       /* MISO */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA0, 0);
+       /* MOSI */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA1, 0);
+       /* SPCK */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA2, 0);
+       /* NPCS0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA3, 0);
+
+       /*
+        * TWI
+        */
+       /* TWD */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA23, 1);
+       /* TWCK */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA24, 1);
+
+       /*
+        * USART0
+        */
+       /* TXD0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB4, 1);
+       /* RXD0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB5, 0);
+       /* DSR0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB22, 0);
+       /* DCD0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB23, 0);
+       /* DTR0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB24, 1);
+       /* RI0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB25, 0);
+       /* RTS0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB26, 1);
+       /* CTS0 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB27, 0);
+
+       /*
+        * USART2
+        */
+       /* RTS2 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA4, 1);
+       /* CTS2 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOA_BASE, AT91C_PIO_PA5, 0);
+       /* TXD2 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB8, 1);
+       /* RXD2 */
+       at91_pio_use_periph_a(AT91SAM9260_PIOB_BASE, AT91C_PIO_PB9, 0);
+
+       return (at91_ramsize());
+}

Modified: stable/9/sys/arm/at91/files.at91sam9
==============================================================================
--- stable/9/sys/arm/at91/files.at91sam9        Sat Jun  2 18:56:41 2012        
(r236467)
+++ stable/9/sys/arm/at91/files.at91sam9        Sat Jun  2 18:57:13 2012        
(r236468)
@@ -31,6 +31,7 @@ arm/at91/at91sam9260.c                optional        at91sam
 #
 # All the boards we support
 #
+arm/at91/board_ethernut5.c     optional        at91_board_ethernut5
 arm/at91/board_hl201.c         optional        at91_board_hl201
 arm/at91/board_sam9g20ek.c     optional        at91_board_sam9g20ek
 arm/at91/board_qila9g20.c      optional        at91_board_qila9g20

Copied: stable/9/sys/arm/at91/std.ethernut5 (from r235348, 
head/sys/arm/at91/std.ethernut5)
==============================================================================
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ stable/9/sys/arm/at91/std.ethernut5 Sat Jun  2 18:57:13 2012        
(r236468, copy of r235348, head/sys/arm/at91/std.ethernut5)
@@ -0,0 +1,14 @@
+# $FreeBSD$
+include "../at91/std.at91sam9"
+
+options        STARTUP_PAGETABLE_ADDR=0x20800000
+makeoptions    KERNPHYSADDR=0x20000000
+makeoptions    KERNVIRTADDR=0xc0000000
+options        KERNPHYSADDR=0x20000000
+options        KERNVIRTADDR=0xc0000000
+
+# SAM9XE512 w/ 90.3168 MHz master clock
+options        AT91C_MASTER_CLOCK=90316800
+
+device         at91_board_ethernut5
+nodevice       at91sam9g20

Copied: stable/9/sys/arm/conf/ETHERNUT5 (from r235348, 
head/sys/arm/conf/ETHERNUT5)
==============================================================================
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ stable/9/sys/arm/conf/ETHERNUT5     Sat Jun  2 18:57:13 2012        
(r236468, copy of r235348, head/sys/arm/conf/ETHERNUT5)
@@ -0,0 +1,158 @@
+# Kernel configuration for Ethernut 5 boards
+#
+# For more information on this file, please read the config(5) manual page,
+# and/or the handbook section on Kernel Configuration Files:
+#
+#    
http://www.FreeBSD.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig-config.html
+#
+# The handbook is also available locally in /usr/share/doc/handbook
+# if you've installed the doc distribution, otherwise always see the
+# FreeBSD World Wide Web server (http://www.FreeBSD.org/) for the
+# latest information.
+#
+# An exhaustive list of options and more detailed explanations of the
+# device lines is also present in the ../../conf/NOTES and NOTES files.
+# If you are in doubt as to the purpose or necessity of a line, check first
+# in NOTES.
+#
+# $FreeBSD$
+
+ident          ETHERNUT5
+
+include "../at91/std.ethernut5"
+
+# To statically compile in device wiring instead of /boot/device.hints
+hints          "ETHERNUT5.hints"
+
+#makeoptions   DEBUG=-g                # Build kernel with gdb(1) debug symbols
+
+options        SCHED_4BSD              # 4BSD scheduler
+#options       PREEMPTION              # Enable kernel thread preemption
+options        INET                    # InterNETworking
+#options       INET6                   # IPv6 communications protocols
+#options       SCTP                    # Stream Control Transmission Protocol
+options        FFS                     # Berkeley Fast Filesystem
+options        SOFTUPDATES             # Enable FFS soft updates support
+#options       UFS_ACL                 # Support for access control lists
+options        UFS_DIRHASH             # Improve performance on big directories
+#options       UFS_GJOURNAL            # Enable gjournal-based UFS journaling
+#options       MD_ROOT                 # MD is a potential root device
+options        NFSCL                   # New Network Filesystem Client
+#options       NFSD                    # New Network Filesystem Server
+options        NFSLOCKD                # Network Lock Manager
+options        NFS_ROOT                # NFS usable as /, requires NFSCL
+#options       MSDOSFS                 # MSDOS Filesystem
+#options       CD9660                  # ISO 9660 Filesystem
+#options       PROCFS                  # Process filesystem (requires PSEUDOFS)
+#options       PSEUDOFS                # Pseudo-filesystem framework
+#options       GEOM_PART_GPT           # GUID Partition Tables.
+#options       GEOM_LABEL              # Provides labelization
+#options       COMPAT_FREEBSD5         # Compatible with FreeBSD5
+#options       COMPAT_FREEBSD6         # Compatible with FreeBSD6
+#options       COMPAT_FREEBSD7         # Compatible with FreeBSD7
+options        SCSI_DELAY=5000         # Delay (in ms) before probing SCSI
+options        KTRACE                  # ktrace(1) support
+#options       STACK                   # stack(9) support
+options        SYSVSHM                 # SYSV-style shared memory
+options        SYSVMSG                 # SYSV-style message queues
+options        SYSVSEM                 # SYSV-style semaphores
+options        _KPOSIX_PRIORITY_SCHEDULING # POSIX P1003_1B real-time 
extensions
+options        PRINTF_BUFR_SIZE=128    # Prevent printf output being 
interspersed.
+#options       HWPMC_HOOKS             # Necessary kernel hooks for hwpmc(4)
+#options       AUDIT                   # Security event auditing
+#options       CAPABILITY_MODE         # Capsicum capability mode
+#options       CAPABILITIES            # Capsicum capabilities
+#options       MAC                     # TrustedBSD MAC Framework
+#options       INCLUDE_CONFIG_FILE     # Include this file in kernel
+
+# required for netbooting
+options        BOOTP_NFSROOT
+options        BOOTP
+options        BOOTP_NFSV3
+options        BOOTP_WIRED_TO=ate0
+options        BOOTP_COMPAT
+
+# alternatively, boot from a MMC/SD memory card
+#options       ROOTDEVNAME=\"ufs:/dev/mmcsd0a\"
+
+# kernel/memory size reduction
+options        MUTEX_NOINLINE
+options        NO_FFS_SNAPSHOT
+options        NO_SWAPPING
+options        NO_SYSCTL_DESCR
+options        RWLOCK_NOINLINE
+
+# Debugging support.  Always need this:
+#options       KDB                     # Enable kernel debugger support.
+# For minimum debugger support (stable branch) use:
+#options       KDB_TRACE               # Print a stack trace for a panic.
+# For full debugger support use this instead:
+#options       DDB                     # Support DDB.
+#options       GDB                     # Support remote GDB.
+#options       DEADLKRES               # Enable the deadlock resolver
+#options       INVARIANTS              # Enable calls of extra sanity checking
+#options       INVARIANT_SUPPORT       # Extra sanity checks of internal 
structures, required by INVARIANTS
+#options       WITNESS                 # Enable checks to detect deadlocks and 
cycles
+#options       WITNESS_SKIPSPIN        # Don't run witness on spinlocks for 
speed
+#options       MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9) zones
+
+# The `bpf' device enables the Berkeley Packet Filter.
+# Be aware of the administrative consequences of enabling this!
+# Note that 'bpf' is required for DHCP.
+device         bpf             # Berkeley packet filter
+
+# Ethernet
+device         mii             # Minimal MII support
+device         ate             # Atmel AT91 Ethernet friver
+
+# I2C
+device         at91_twi        # Atmel AT91 Two-wire Interface
+device         iic             # I2C generic I/O device driver
+device         iicbus          # I2C bus system
+device         pcf8563         # NXP PCF8563 clock/calendar
+
+# MMC/SD
+device         at91_mci        # Atmel AT91 Multimedia Card Interface
+options        AT91_MCI_HAS_4WIRE
+device         mmc             # MMC/SD bus
+device         mmcsd           # MMC/SD memory card
+
+# DataFlash - totally b0rken drivers
+#device                at91_spi        # Atmel AT91 Serial Peripheral Interface
+#device                spibus          # SPI bus
+#device                at45d           # Atmel AT45D
+#device                geom_map        # GEOM partition mapping
+
+# Pseudo devices.
+device         loop            # Network loopback
+device         random          # Entropy device
+device         ether           # Ethernet support
+#device                vlan            # 802.1Q VLAN support
+#device                tun             # Packet tunnel.
+#device                md              # Memory "disks"
+#device                gif             # IPv6 and IPv4 tunneling
+#device                faith           # IPv6-to-IPv4 relaying (translation)
+#device                firmware        # firmware assist module
+
+# SCSI peripherals
+#device                scbus           # SCSI bus (required for ATA/SCSI)
+#device                ch              # SCSI media changers
+#device                da              # Direct Access (disks)
+#device                sa              # Sequential Access (tape etc)
+#device                cd              # CD
+#device                pass            # Passthrough device (direct ATA/SCSI 
access)
+#device                ses             # SCSI Environmental Services (and 
SAF-TE)
+#device                ctl             # CAM Target Layer
+
+# Serial (COM) ports
+device         uart            # Multi-uart driver
+options        ALT_BREAK_TO_DEBUGGER
+
+# USB support
+#options       USB_DEBUG       # enable debug msgs
+device         ohci            # OHCI PCI->USB interface
+device         usb             # USB Bus (required)
+#device                umass           # Disks/Mass storage - Requires scbus 
and da
+
+# watchdog
+device         at91_wdt        # Atmel AT91 Watchdog Timer

Copied: stable/9/sys/arm/conf/ETHERNUT5.hints (from r235348, 
head/sys/arm/conf/ETHERNUT5.hints)
==============================================================================
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ stable/9/sys/arm/conf/ETHERNUT5.hints       Sat Jun  2 18:57:13 2012        
(r236468, copy of r235348, head/sys/arm/conf/ETHERNUT5.hints)
@@ -0,0 +1,45 @@
+# $FreeBSD$
+
+# Atmel AT45DB21D
+hint.at45d.0.at="spibus0"
+hint.at45d.0.addr=0x00
+# user 132 kbytes
+hint.map.0.at="flash/spi0"
+hint.map.0.start=0x00000000
+hint.map.0.end=0x00020fff
+hint.map.0.name="user"
+hint.map.0.readonly=1
+# setup 132 kbytes
+hint.map.1.at="flash/spi0"
+hint.map.1.start=0x00021000
+hint.map.1.end=0x00041fff
+hint.map.1.name="setup"
+hint.map.1.readonly=1
+# uboot 528 kbytes
+hint.map.2.at="flash/spi0"
+hint.map.2.start=0x00042000
+hint.map.2.end=0x000c5fff
+hint.map.2.name="uboot"
+hint.map.2.readonly=1
+# kernel 2640 kbytes
+hint.map.3.at="flash/spi0"
+hint.map.3.start=0x000c6000
+hint.map.3.end=0x00359fff
+hint.map.3.name="kernel"
+#hint.map.3.readonly=1
+# nutos 3432 kbytes
+hint.map.4.at="flash/spi0"
+hint.map.4.start=0x0035a000
+hint.map.4.end=0x003ddfff
+hint.map.4.name="nutos"
+hint.map.4.readonly=1
+# env 3960 kbytes
+hint.map.5.at="flash/spi0"
+hint.map.5.start=0x003de000
+hint.map.5.end=0x003fefff
+hint.map.5.name="env"
+hint.map.5.readonly=1
+
+# NXP PCF8563 clock/calendar
+hint.pcf8563_rtc.0.at="iicbus0"
+hint.pcf8563_rtc.0.addr=0xa2

Modified: stable/9/sys/dev/sym/sym_conf.h
==============================================================================
--- stable/9/sys/dev/sym/sym_conf.h     Sat Jun  2 18:56:41 2012        
(r236467)
+++ stable/9/sys/dev/sym/sym_conf.h     Sat Jun  2 18:57:13 2012        
(r236468)
@@ -83,6 +83,13 @@
 #define SYM_CONF_MAX_TAG_ORDER (6)
 
 /*
+ *  DMA boundary
+ *  We need to ensure 16 MB boundaries not to be crossed during DMA of
+ *  each segment, due to some chips being flawed.
+ */
+#define SYM_CONF_DMA_BOUNDARY  (1UL << 24)
+
+/*
  *  Max number of scatter/gather entries for en IO.
  *  Each entry costs 8 bytes in the internal CCB data structure.
  *  For now 65 should suffice given the BSD O/Ses capabilities.

Modified: stable/9/sys/dev/sym/sym_hipd.c
==============================================================================
--- stable/9/sys/dev/sym/sym_hipd.c     Sat Jun  2 18:56:41 2012        
(r236467)
+++ stable/9/sys/dev/sym/sym_hipd.c     Sat Jun  2 18:57:13 2012        
(r236468)
@@ -1623,6 +1623,7 @@ struct sym_hcb {
        u_int   features;       /* Chip features map            */
        u_char  myaddr;         /* SCSI id of the adapter       */
        u_char  maxburst;       /* log base 2 of dwords burst   */
+       u_char  maxsegcnt;      /* Max DMA S/G segments         */
        u_char  maxwide;        /* Maximum transfer width       */
        u_char  minsync;        /* Min sync period factor (ST)  */
        u_char  maxsync;        /* Max sync period factor (ST)  */
@@ -7988,10 +7989,7 @@ sym_fast_scatter_sg_physical(hcb_p np, c
 
 /*
  *  Scatter a SG list with physical addresses into bus addressable chunks.
- *  We need to ensure 16MB boundaries not to be crossed during DMA of
- *  each segment, due to some chips being flawed.
  */
-#define BOUND_MASK ((1UL<<24)-1)
 static int
 sym_scatter_sg_physical(hcb_p np, ccb_p cp, bus_dma_segment_t *psegs, int 
nsegs)
 {
@@ -8007,7 +8005,7 @@ sym_scatter_sg_physical(hcb_p np, ccb_p 
        pe = ps + psegs[t].ds_len;
 
        while (s >= 0) {
-               pn = (pe - 1) & ~BOUND_MASK;
+               pn = (pe - 1) & ~(SYM_CONF_DMA_BOUNDARY - 1);
                if (pn <= ps)
                        pn = ps;
                k = pe - pn;
@@ -8032,17 +8030,21 @@ sym_scatter_sg_physical(hcb_p np, ccb_p 
 
        return t >= 0 ? -1 : 0;
 }
-#undef BOUND_MASK
 
 /*
  *  SIM action for non performance critical stuff.
  */
 static void sym_action2(struct cam_sim *sim, union ccb *ccb)
 {
+       union ccb *abort_ccb;
+       struct ccb_hdr *ccb_h;
+       struct ccb_pathinq *cpi;
+       struct ccb_trans_settings *cts;
+       struct sym_trans *tip;
        hcb_p   np;
        tcb_p   tp;
        lcb_p   lp;
-       struct  ccb_hdr  *ccb_h;
+       u_char dflags;
 
        /*
         *  Retrieve our controller data structure.
@@ -8055,9 +8057,6 @@ static void sym_action2(struct cam_sim *
 
        switch (ccb_h->func_code) {
        case XPT_SET_TRAN_SETTINGS:
-       {
-               struct ccb_trans_settings *cts;
-
                cts  = &ccb->cts;
                tp = &np->target[ccb_h->target_id];
 
@@ -8079,13 +8078,7 @@ static void sym_action2(struct cam_sim *
 
                sym_xpt_done2(np, ccb, CAM_REQ_CMP);
                break;
-       }
        case XPT_GET_TRAN_SETTINGS:
-       {
-               struct ccb_trans_settings *cts;
-               struct sym_trans *tip;
-               u_char dflags;
-
                cts = &ccb->cts;
                tp = &np->target[ccb_h->target_id];
                lp = sym_lp(np, tp, ccb_h->target_lun);
@@ -8129,16 +8122,12 @@ static void sym_action2(struct cam_sim *
 #undef cts__scsi
                sym_xpt_done2(np, ccb, CAM_REQ_CMP);
                break;
-       }
        case XPT_CALC_GEOMETRY:
-       {
                cam_calc_geometry(&ccb->ccg, /*extended*/1);
                sym_xpt_done2(np, ccb, CAM_REQ_CMP);
                break;
-       }
        case XPT_PATH_INQ:
-       {
-               struct ccb_pathinq *cpi = &ccb->cpi;
+               cpi = &ccb->cpi;
                cpi->version_num = 1;
                cpi->hba_inquiry = PI_MDP_ABLE|PI_SDTR_ABLE|PI_TAG_ABLE;
                if ((np->features & FE_WIDE) != 0)
@@ -8173,12 +8162,11 @@ static void sym_action2(struct cam_sim *
                        cpi->xport_specific.spi.ppr_options =
                            SID_SPI_CLOCK_DT_ST;
                }
+               cpi->maxio = np->maxsegcnt * SYM_CONF_DMA_BOUNDARY;
                sym_xpt_done2(np, ccb, CAM_REQ_CMP);
                break;
-       }
        case XPT_ABORT:
-       {
-               union ccb *abort_ccb = ccb->cab.abort_ccb;
+               abort_ccb = ccb->cab.abort_ccb;
                switch(abort_ccb->ccb_h.func_code) {
                case XPT_SCSI_IO:
                        if (sym_abort_scsiio(np, abort_ccb, 0) == 0) {
@@ -8190,14 +8178,10 @@ static void sym_action2(struct cam_sim *
                        break;
                }
                break;
-       }
        case XPT_RESET_DEV:
-       {
                sym_reset_dev(np, ccb);
                break;
-       }
        case XPT_RESET_BUS:
-       {
                sym_reset_scsi_bus(np, 0);
                if (sym_verbose) {
                        xpt_print_path(np->path);
@@ -8206,7 +8190,6 @@ static void sym_action2(struct cam_sim *
                sym_init (np, 1);
                sym_xpt_done2(np, ccb, CAM_REQ_CMP);
                break;
-       }
        case XPT_ACCEPT_TARGET_IO:
        case XPT_CONT_TARGET_IO:
        case XPT_EN_LUN:
@@ -8362,7 +8345,7 @@ sym_update_dflags(hcb_p np, u_char *flag
 static device_method_t sym_pci_methods[] = {
        DEVMETHOD(device_probe,  sym_pci_probe),
        DEVMETHOD(device_attach, sym_pci_attach),
-       { 0, 0 }
+       DEVMETHOD_END
 };
 
 static driver_t sym_pci_driver = {
@@ -8373,7 +8356,7 @@ static driver_t sym_pci_driver = {
 
 static devclass_t sym_devclass;
 
-DRIVER_MODULE(sym, pci, sym_pci_driver, sym_devclass, 0, 0);
+DRIVER_MODULE(sym, pci, sym_pci_driver, sym_devclass, NULL, NULL);
 MODULE_DEPEND(sym, cam, 1, 1, 1);
 MODULE_DEPEND(sym, pci, 1, 1, 1);
 
@@ -8586,15 +8569,16 @@ sym_pci_attach(device_t dev)
        /*
         *  Allocate a tag for the DMA of user data.
         */
-       if (bus_dma_tag_create(np->bus_dmat, 1, (1<<24),
-                               BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR,
-                               NULL, NULL,
-                               BUS_SPACE_MAXSIZE, SYM_CONF_MAX_SG,
-                               (1<<24), 0, busdma_lock_mutex, &np->mtx,
-                               &np->data_dmat)) {
+       np->maxsegcnt = MIN(SYM_CONF_MAX_SG,
+           (MAXPHYS / SYM_CONF_DMA_BOUNDARY) + 1);
+       if (bus_dma_tag_create(np->bus_dmat, 1, SYM_CONF_DMA_BOUNDARY,
+           BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
+           BUS_SPACE_MAXSIZE, np->maxsegcnt, SYM_CONF_DMA_BOUNDARY,
+           BUS_DMA_ALLOCNOW, busdma_lock_mutex, &np->mtx, &np->data_dmat)) {
                device_printf(dev, "failed to create DMA tag.\n");
                goto attach_failed;
        }
+
        /*
         *  Read and apply some fix-ups to the PCI COMMAND
         *  register. We want the chip to be enabled for:
@@ -8603,9 +8587,8 @@ sym_pci_attach(device_t dev)
         *  - Write And Invalidate.
         */
        command = pci_read_config(dev, PCIR_COMMAND, 2);
-       command |= PCIM_CMD_BUSMASTEREN;
-       command |= PCIM_CMD_PERRESPEN;
-       command |= /* PCIM_CMD_MWIEN */ 0x0010;
+       command |= PCIM_CMD_BUSMASTEREN | PCIM_CMD_PERRESPEN |
+           PCIM_CMD_MWRICEN;
        pci_write_config(dev, PCIR_COMMAND, command, 2);
 
        /*
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to