on 01/08/2012 03:29 Ben Kaduk said the following: > On Tue, Jul 31, 2012 at 8:18 PM, Adrian Chadd <[email protected]> wrote: >> --- head/sys/dev/ath/ath_rate/sample/sample.c Tue Jul 31 23:54:15 2012 >> (r238961) >> +++ head/sys/dev/ath/ath_rate/sample/sample.c Wed Aug 1 00:18:02 2012 >> (r238962) >> @@ -504,7 +504,7 @@ ath_rate_findrate(struct ath_softc *sc, >> >> mrr = sc->sc_mrretry; >> /* XXX check HT protmode too */ >> - if (mrr && (ic->ic_flags & IEEE80211_F_USEPROT) && !sc->sc_mrrprot) >> + if (mrr && (ic->ic_flags & IEEE80211_F_USEPROT && !sc->sc_mrrprot)) >> mrr = 0; >> >> best_rix = pick_best_rate(an, rt, size_bin, !mrr); > > Logical '&&' evaluates left-to-right already, so I do not see that the > current parentheses are needed?
Yeah, adding "!= 0" after the bitwise operation would be much more logical than shuffling the otherwise useless parentheses. -- Andriy Gapon _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "[email protected]"
