Author: emaste
Date: Wed Oct 17 20:23:07 2012
New Revision: 241648
URL: http://svn.freebsd.org/changeset/base/241648

Log:
  Avoid potential bad pointer dereference.
  
  Previously RuleAdd would leave entry->la unset for the first entry in
  the proxyList.
  
  Sponsored by: ADARA Networks
  MFC After: 1 week

Modified:
  head/sys/netinet/libalias/alias_proxy.c

Modified: head/sys/netinet/libalias/alias_proxy.c
==============================================================================
--- head/sys/netinet/libalias/alias_proxy.c     Wed Oct 17 20:17:56 2012        
(r241647)
+++ head/sys/netinet/libalias/alias_proxy.c     Wed Oct 17 20:23:07 2012        
(r241648)
@@ -210,13 +210,13 @@ RuleAdd(struct libalias *la, struct prox
 
        LIBALIAS_LOCK_ASSERT(la);
 
+       entry->la = la;
        if (la->proxyList == NULL) {
                la->proxyList = entry;
                entry->last = NULL;
                entry->next = NULL;
                return;
        }
-       entry->la = la;
 
        rule_index = entry->rule_index;
        ptr = la->proxyList;
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to