On 28 October 2012 03:42, Davide Italiano <dav...@freebsd.org> wrote: > Author: davide > Date: Sat Oct 27 23:42:41 2012 > New Revision: 242202 > URL: http://svn.freebsd.org/changeset/base/242202 > > Log: > The fields of struct timespec32 should be int32_t and not uint32_t. > Make this change. > > Reviewed by: bde, davidxu > Tested by: pho > MFC after: 1 week > > Modified: > head/sys/kern/kern_umtx.c > > Modified: head/sys/kern/kern_umtx.c > ============================================================================== > --- head/sys/kern/kern_umtx.c Sat Oct 27 23:36:41 2012 (r242201) > +++ head/sys/kern/kern_umtx.c Sat Oct 27 23:42:41 2012 (r242202) > @@ -3291,8 +3291,8 @@ freebsd32_umtx_unlock(struct thread *td, > } > > struct timespec32 { > - uint32_t tv_sec; > - uint32_t tv_nsec; > + int32_t tv_sec; > + int32_t tv_nsec; > }; > > struct umtx_time32 {
Thanks. It could be fine to take this from compat/freebsd32, OTOH it hardly makes sense for me. IMHO duplicating a single struct definition is sometimes lesser evil than inclusion pile of unused stuff from yet another header(s). -- wbr, pluknet _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
