Mike Telahun <mike.tela...@gmail.com> wrote in <50ab19d3.9080...@gmail.com>:
mi> > @@ -704,7 +704,10 @@ run_rc_command()
mi> >
mi> > start)
mi> > if [ -z "$rc_fast" -a -n "$rc_pid" ]; then
mi> > - echo 1>&2 "${name} already running?
(pid=$rc_pid)."
mi> > + if [ -z "$rc_quiet" ]; then
mi>
mi> Shouldn't this be using checkyesno() ?
mi> What happens if someone has rc_quiet=NO in /etc/rc.conf?
rc_fast, rc_force, and rc_quiet are not intended to be used in
/etc/rc.conf or other config files. These variables have no default
value and will be defined forcibly via {fast,force,quiet}start. If
we use checkyesno() here, it checks whether a variable is defined or
not and then put an warning message when not defined. It is a bad
side-effect for them.
-- Hiroki
pgprTKhxXTT9y.pgp
Description: PGP signature
