Author: dim
Date: Wed Dec 19 12:19:45 2012
New Revision: 244430
URL: http://svnweb.freebsd.org/changeset/base/244430
Log:
MFC r243907:
Fix an old bug in devd, where it uses std::sort() to sort the various
lists it reads from its configuration files on the priority field.
Because some items in the lists have the same priority, and std::sort()
is not stable, the exact order in which the items are enumerated does
not have to correspond to the order they appear in the configuration
files.
Apparently this was never noticed with libstdc++, but with libc++ it
could cause the "uhid" entry from /etc/devd/usb.conf to be used instead
of the "ums" entry (which is earlier in the file). This caused the
problem described in the PR: the USB mouse module was never loaded, and
the other actions (such as starting moused) were not executed.
To fix the problem, make devd use std:stable_sort() instead.
Reported by: Jan Beich <jbe...@tormail.org>
PR: bin/172958
Modified:
stable/9/sbin/devd/devd.cc
Directory Properties:
stable/9/sbin/devd/ (props changed)
Modified: stable/9/sbin/devd/devd.cc
==============================================================================
--- stable/9/sbin/devd/devd.cc Wed Dec 19 12:14:08 2012 (r244429)
+++ stable/9/sbin/devd/devd.cc Wed Dec 19 12:19:45 2012 (r244430)
@@ -436,7 +436,7 @@ public:
void
config::sort_vector(vector<event_proc *> &v)
{
- sort(v.begin(), v.end(), epv_greater());
+ stable_sort(v.begin(), v.end(), epv_greater());
}
void
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
