Author: ae
Date: Thu Aug  8 11:24:25 2013
New Revision: 254092
URL: http://svnweb.freebsd.org/changeset/base/254092

Log:
  Make the check for number of entries less strict.
  Some partitioning tools can create GPT with number of entries less
  than 128.
  
  MFC after:    1 week

Modified:
  head/sys/boot/common/part.c

Modified: head/sys/boot/common/part.c
==============================================================================
--- head/sys/boot/common/part.c Thu Aug  8 09:04:02 2013        (r254091)
+++ head/sys/boot/common/part.c Thu Aug  8 11:24:25 2013        (r254092)
@@ -181,7 +181,7 @@ gpt_checkhdr(struct gpt_hdr *hdr, uint64
        }
        hdr->hdr_entries = le32toh(hdr->hdr_entries);
        hdr->hdr_entsz = le32toh(hdr->hdr_entsz);
-       if (hdr->hdr_entries < 128 ||
+       if (hdr->hdr_entries == 0 ||
            hdr->hdr_entsz < sizeof(struct gpt_ent) ||
            sectorsize % hdr->hdr_entsz != 0) {
                DEBUG("invalid entry size or number of entries");
@@ -203,11 +203,14 @@ gpt_checktbl(const struct gpt_hdr *hdr, 
        int i, cnt;
 
        cnt = size / hdr->hdr_entsz;
-       /* Check CRC only when buffer size is enough for table. */
-       if (hdr->hdr_entries <= cnt &&
-           crc32(tbl, size) != hdr->hdr_crc_table) {
-               DEBUG("GPT table's CRC doesn't match");
-               return (-1);
+       if (hdr->hdr_entries <= cnt) {
+               cnt = hdr->hdr_entries;
+               /* Check CRC only when buffer size is enough for table. */
+               if (hdr->hdr_crc_table !=
+                   crc32(tbl, hdr->hdr_entries * hdr->hdr_entsz)) {
+                       DEBUG("GPT table's CRC doesn't match");
+                       return (-1);
+               }
        }
        ent = (struct gpt_ent *)tbl;
        for (i = 0; i < cnt; i++, ent++) {
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "[email protected]"

Reply via email to