On Sun, Jun 08, 2014 at 05:38:49PM +0000, Bjoern A. Zeeb wrote: > > On 08 Jun 2014, at 17:29 , Bryan Drewery <bdrew...@freebsd.org> wrote: > > > Author: bdrewery > > Date: Sun Jun 8 17:29:31 2014 > > New Revision: 267233 > > URL: http://svnweb.freebsd.org/changeset/base/267233 > > > > Log: > > In preparation for ASLR [1] support add WITH_PIE to support building with > > -fPIE. > > > > This is currently an opt-in build flag. Once ASLR support is ready and > > stable > > it should changed to opt-out and be enabled by default along with ASLR. > > > > Each application Makefile uses opt-out to ensure that ASLR will be enabled > > by > > default in new directories when the system is compiled with PIE/ASLR. [2] > > > > Mark known build failures as NO_PIE for now. > > No, no, no, no more NOs! > > I?ll leave it to others who understand the current build system in days when > it?s not broken to fix this entire splattering across all these Makefiles; > we really need a better way for this.
I have no words to express my dissatisfaction with this commit. If change to the build of _some_ usermode binaries require patching of loader', csu and rtld Makefiles, obviously it is done wrong. Why almost half of the binaries require opt-out ? PLEASE REVERT THIS.
pgp0FREEU5Ez4.pgp
Description: PGP signature