> Den 22/01/2015 kl. 09.39 skrev Hans Petter Selasky <h...@selasky.org>: > > Are you saying that pieces of code that runs completely unlocked using > "volatile" as only synchronization mechanism is better than what I would call > a temporary and hopefully short TCP stack performance loss? > > I don't understand? How frequently do you reboot your boxes? Maybe one every > day? And you don't care?
Hans, I'm just a spectator here, but please do yourself and the project a favor and back out your change, go back to the Phabricator review once more and let the review process roll until everyone is satisfied. Although it's not very evident in this thread, I'm sure everyone actually appreciates your work. I also acknowledge that it's frustrating to back out a commit that you have spent a lot of effort on, and which fixes actual bugs. It's also frustrating to get insufficient feedback on a code review, but you certainly got people's attention now. Now you need to trust that the people voicing concerns will step up and provide constructive feedback in Phabricator, so this can be committed in a timely manner, in a quality that we expect from FreeBSD. Kind regards, Erik
signature.asc
Description: Message signed with OpenPGP using GPGMail
