On Mon, Jan 26, 2015 at 06:26:54PM -0800, Garrett Cooper wrote: > On Jan 26, 2015, at 4:23, Dag-Erling Smorgrav <d...@des.no> wrote: > > Garrett Cooper <n...@freebsd.org> writes: > >> Log: > >> Honor MK_ACCT with etc/pam.d/atrun > > > > The correct idiom would be > > I disagree for a few reasons: [...] > 2. The likelihood of typos creeping into Makefiles is greater with the > _foo= idiom. > 3. It creates unnecessary local variables - especially when appending is > so easy to do. > 4. It's more difficult when backporting changes to do it with the variable > method - especially if context around the line modified has changed a > great deal.
As someone who writes makefile daily I would agree, but there should be a reason why it was always done with _foo. One obvious one is that it shows up front all possible values, including conditional ones, which can also help not to forget something when backporting changes somewhere else. ;-) ./danfe _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
