On Sat, 06 Mar 2010 11:41:27 -0800 Doug Barton <[email protected]>
wrote:

> On 3/6/2010 7:25 AM, Alexander Leidinger wrote:

> > The trick with command_args is neat, but it is a pitfall in case
> > someone wants to use it in the future. Wouldn't it be better to add
> > the ampersand to it instead of letting the ampersand replace the
> > value?
> 
> Yes, obviously if someone wants to use command_args for an additional 
> purpose down the road changes will have to be made. It's not in use
> atm however, so IMO simpler is better.

In general I agree to KISS, but the change now would be
  command_args="${command_args}&"
which is not complex at all and is safer for the future.

Bye,
Alexander.
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "[email protected]"

Reply via email to