Author: luigi Date: Mon Apr 12 08:27:53 2010 New Revision: 206494 URL: http://svn.freebsd.org/changeset/base/206494
Log: fix a buffer overflow with large (100k+) number of input lines. MFC after: 3 days Modified: head/sbin/ipfw/main.c Modified: head/sbin/ipfw/main.c ============================================================================== --- head/sbin/ipfw/main.c Sun Apr 11 21:59:23 2010 (r206493) +++ head/sbin/ipfw/main.c Mon Apr 12 08:27:53 2010 (r206494) @@ -553,11 +553,11 @@ ipfw_readfile(int ac, char *av[]) } while (fgets(buf, BUFSIZ, f)) { /* read commands */ - char linename[10]; + char linename[20]; char *args[2]; lineno++; - sprintf(linename, "Line %d", lineno); + snprintf(linename, sizeof(linename), "Line %d", lineno); setprogname(linename); /* XXX */ args[0] = progname; args[1] = buf; _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"