On Mon, Apr 12, 2010 at 11:05:12PM +0200, Luigi Rizzo wrote: > On Mon, Apr 12, 2010 at 10:49:26PM +0200, Pawel Jakub Dawidek wrote: > ... > > > @@ -0,0 +1,19 @@ > > > +# GEOM_LIBRARY_PATH > > > +# $FreeBSD$ > > > + > > > +.PATH: /usr/src/sbin/geom/misc > > > + > > > +CFLAGS += -I/usr/src/sbin/geom > > > > This doesn't look right. > > probably a leftover from older versions of this code for 6.x . > I will do more tests tomorrow (for 7.x at this point, there is > no point in trying to support 6.x I believe) and try to remove > it if not necessary.
As Rui said you should use ${.CURDIR} instead of hardcoding /usr/src/.
BTW. So you decided to implement insert/remove functionality after all.
I have some questions:
- It is implemented as internal gsched hack, which is a pity, because
this might be very useful functionality for other classes in the future.
Is there a plan to make it more general and move it to the GEOM itself?
- Why g_sched_flush_pending() operates on global structure? I think it
will break if you try to insert and remove at the same time.
--
Pawel Jakub Dawidek http://www.wheelsystems.com
p...@freebsd.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
pgpAKv7NSWhnx.pgp
Description: PGP signature
