Author: jhb
Date: Thu Aug 19 16:40:30 2010
New Revision: 211514
URL: http://svn.freebsd.org/changeset/base/211514

Log:
  There isn't really a need to hold the ktrace mutex just to read the value
  of p_traceflag that is stored in the kinfo_proc structure.  It is still
  racey even with the lock and the code will read a consistent snapshot of
  the flag without the lock.

Modified:
  head/sys/kern/kern_proc.c

Modified: head/sys/kern/kern_proc.c
==============================================================================
--- head/sys/kern/kern_proc.c   Thu Aug 19 16:39:00 2010        (r211513)
+++ head/sys/kern/kern_proc.c   Thu Aug 19 16:40:30 2010        (r211514)
@@ -64,10 +64,6 @@ __FBSDID("$FreeBSD$");
 #include <sys/jail.h>
 #include <sys/vnode.h>
 #include <sys/eventhandler.h>
-#ifdef KTRACE
-#include <sys/uio.h>
-#include <sys/ktrace.h>
-#endif
 
 #ifdef DDB
 #include <ddb/ddb.h>
@@ -717,9 +713,7 @@ fill_kinfo_proc_only(struct proc *p, str
        kp->ki_textvp = p->p_textvp;
 #ifdef KTRACE
        kp->ki_tracep = p->p_tracevp;
-       mtx_lock(&ktrace_mtx);
        kp->ki_traceflag = p->p_traceflag;
-       mtx_unlock(&ktrace_mtx);
 #endif
        kp->ki_fd = p->p_fd;
        kp->ki_vmspace = p->p_vmspace;
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to