Author: rpaulo
Date: Wed Oct 13 17:17:50 2010
New Revision: 213793
URL: http://svn.freebsd.org/changeset/base/213793
Log:
Don't do a logical AND of the result of strcmp() with a constant.
Found with: clang
Modified:
head/sys/dev/ce/if_ce.c
head/sys/dev/cp/if_cp.c
Modified: head/sys/dev/ce/if_ce.c
==============================================================================
--- head/sys/dev/ce/if_ce.c Wed Oct 13 17:16:08 2010 (r213792)
+++ head/sys/dev/ce/if_ce.c Wed Oct 13 17:17:50 2010 (r213793)
@@ -1313,7 +1313,7 @@ static int ce_ioctl (struct cdev *dev, u
IFP2SP(d->ifp)->pp_flags &= ~(PP_FR);
IFP2SP(d->ifp)->pp_flags |= PP_KEEPALIVE;
d->ifp->if_flags |= PP_CISCO;
- } else if (! strcmp ("fr", (char*)data) && PP_FR) {
+ } else if (! strcmp ("fr", (char*)data)) {
d->ifp->if_flags &= ~(PP_CISCO);
IFP2SP(d->ifp)->pp_flags |= PP_FR | PP_KEEPALIVE;
} else if (! strcmp ("ppp", (char*)data)) {
Modified: head/sys/dev/cp/if_cp.c
==============================================================================
--- head/sys/dev/cp/if_cp.c Wed Oct 13 17:16:08 2010 (r213792)
+++ head/sys/dev/cp/if_cp.c Wed Oct 13 17:17:50 2010 (r213793)
@@ -1052,7 +1052,7 @@ static int cp_ioctl (struct cdev *dev, u
IFP2SP(d->ifp)->pp_flags &= ~(PP_FR);
IFP2SP(d->ifp)->pp_flags |= PP_KEEPALIVE;
d->ifp->if_flags |= PP_CISCO;
- } else if (! strcmp ("fr", (char*)data) && PP_FR) {
+ } else if (! strcmp ("fr", (char*)data)) {
d->ifp->if_flags &= ~(PP_CISCO);
IFP2SP(d->ifp)->pp_flags |= PP_FR | PP_KEEPALIVE;
} else if (! strcmp ("ppp", (char*)data)) {
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
