On 01/06/11 04:47, John Baldwin wrote: > On Thursday, January 06, 2011 4:02:43 am Julian Elischer wrote: >> On 1/6/11 12:33 AM, Edward Tomasz Napierala wrote: >>> -Code that cannot be reached should have a >>> -.Li NOTREACHED >>> -comment. > > Clutter. It should be very obvious that exit(), err*(), pthread_exit(), > kthread_exit(), kproc_exit() and even usage() all terminate without returning > (the last not required, just a very common convention). [...]
However, it might not be so obvious following long 'for (;;)' loops which return rather than breaking. I'd prefer to see the remark stay in style(9) with an added "in cases where this isn't immediately obvious from the surrounding code" clause. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "[email protected]"
