On 10/22/2018 11:31 PM, Alex Richardson wrote: > Author: arichardson > Date: Tue Oct 23 06:31:25 2018 > New Revision: 339636 > URL: https://svnweb.freebsd.org/changeset/base/339636 > > Log: > Only compute the X_COMPILER_*/X_LINKER_* variables when needed > > When building CheriBSD we have to set XLD/XCC/XCFLAGS on the command line. > This triggers the $XCC != $CC case in bsd.compiler.mk (and the same for LD > in bsd.linker.mk) which causes it to call ${XCC} --version and > ${XLD} --version (plus various awk+sed+echo calls) in every subdirectory. > For incremental builds and stages that only walk the source tree this is > often the majority of the time spent in that directory. > ...
> By only computing the value of the X_COMPILER_*/X_LINKER_* variables if > _WANT_TOOLCHAIN_CROSS_VARS is set we can reduce the number of cc/ld calls > to once per build stage instead of once per recursive make. This sounds wrong. bsd.compiler.mk *already* handles that kind of thing by exporting its computations. Adding a second hack for a similar problem isn't the right solution. > > With this change (and no changes to the sources) the `make includes` stage > now takes 28 seconds at -j1 instead of 86 seconds. > > Approved By: brooks (mentor) > Differential Revision: https://reviews.freebsd.org/D17046 -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature