Hi Eugene, On Thu, Nov 29, 2018 at 6:22 AM Eugene Grosbein <eu...@freebsd.org> wrote: > > Author: eugen > Date: Thu Nov 29 14:21:26 2018 > New Revision: 341232 > URL: https://svnweb.freebsd.org/changeset/base/341232 > > Log: > Add new small tool trim(1) to delete contents for blocks on flash > based storage devices that use wear-leveling algorithms. > > Reviewed by: hackers@ > MFC after: 1 month
As much as I also want a tool like this, please back out the commit for now. It was never code reviewed; that's what the "Reviewed by:" annotation means. It was *discussed*, but not universally approved, on hackers@. I think this should probably be backed out and at least given basic code review first. I volunteer to do that in a timely fashion myself; there is at least one glaring issue in the tool just scanning the code. It should have some basic review before anything like "MFC after" is suggested and we commit to basically adding a userspace API. At least Warner, and possibly others, should be on the review as well. Thanks, Conrad _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
