On 22.01.2020 15:59, Alexander V. Chernikov wrote: > 22.01.2020, 20:36, "Alexander Motin" <m...@freebsd.org>: >> Author: mav >> Date: Wed Jan 22 20:36:45 2020 >> New Revision: 356993 >> URL: https://svnweb.freebsd.org/changeset/base/356993 >> >> Log: >> Update route MTUs for bridge, lagg and vlan interfaces. >> >> Those interfaces may implicitly change their MTU on addition of parent >> interface in addition to normal SIOCSIFMTU ioctl path, where the route >> MTUs are updated normally. >> >> MFC after: 2 weeks >> Sponsored by: iXsystems, Inc. >> >> Modified: >> head/sys/net/if_bridge.c >> head/sys/net/if_lagg.c >> head/sys/net/if_vlan.c > I'd suggest not duplicating business logic on providing notifications to > multiple subsystems in each driver. This adds unnecessary complexity/layer > violations. What do you think of creating something like > if_notify_mtu_change(), embed these 2 calls there and use it everywhere?
I'd be happy to use such KPI, but would prefer somebody more familiar with modern ifnet tendencies then me to design it. ;) -- Alexander Motin _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
