On Tuesday, June 07, 2011 11:39:26 am Jung-uk Kim wrote: > On Tuesday 07 June 2011 09:52 am, John Baldwin wrote: > The whole point of this commit is to blacklist *recent* BIOS (or CSM) > from probing keyboard typematic information, more specifically, > recent Intel chipset platforms. They don't support many INT 15h/16h > functions but only cause trouble at best. OTOH, I haven't seen such > problems with AMD chipset systems and they all seem to have > traditional entry points at the interrupt vector table, for example.
Err, but you didn't blacklist recent BIOS. You blacklist _all_ BIOS that use entry points other than the ones from the UEFI spec, including BIOSes that don't claim to support UEFI and the BIOS from the two systems I quoted. > > You might as well just turn the check off on all machines at this > > point rather than using completely arbitrary tests that are only > > valid on a small fraction of the x86 universe. > > I don't think it is "completely" arbitrary. If it doesn't have the > traditional entry points, it is very unlikely to support keyboard > typematic in the first place. Please let me know if you have any > counter example. Umm, I just gave you two examples. UEFI is not a standard appropriate to the vast majority of x86 BIOS implementations. It is far, far too narrow. Put another way, we should assume that all non-recent BIOSes do not conform to UEFI (since many older systems pre-date the UEFI spec for one) and that they have all been effectively blacklisted now. Given that, you've now restricted this functionality to only a subset of recent BIOSes and have blacklisted the rest of the known universe. However, the simplest fix is probably to just remove this entirely as I doubt anyone really depends on the BIOS settings for these anyway. -- John Baldwin _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "[email protected]"
