On Tue, Oct 16, 2012 at 05:09:31AM +1100, Bruce Evans wrote: B> > On Mon, Oct 15, 2012 at 06:36:58PM +0400, Gleb Smirnoff wrote: B> >> On Mon, Oct 15, 2012 at 08:34:09AM -0400, John Baldwin wrote: B> >> J> On Sunday, October 14, 2012 11:03:07 am Gleb Smirnoff wrote: B> >> J> > Author: glebius B> >> J> > Date: Sun Oct 14 15:03:06 2012 B> >> J> > New Revision: 241546 B> >> J> > URL: http://svn.freebsd.org/changeset/base/241546 B> > B> >> J> > Log: B> >> J> > Fix defines in r241245. We actually don't define FreeBSD. B> > B> >> J> > Reported & tested by: Oleg Ginzburg B> > B> >> J> Seems like it should be using 'defined(__FreeBSD_version)' instead? B> > B> >> AFAIU, the construction which left after r241546 works fine. Anything B> >> undefined resolves to zero, so in case of non-FreeBSD build we test B> >> if (0 > 10000019) and this fails which is what we expect. B> > B> >> I have used this construction several times already without any side B> >> effects. I have also seen it in some software in ports, where it works B> >> okay, too. B> > B> > The C standard indeed permits this, but gcc -Wundef will warn about it. B> > That compiler warning is in CWARNFLAGS in sys/conf/kern.mk so I suggest B> > adding the 'defined(__FreeBSD_version) &&'. B> B> The C standard requires this, but some misconfigured compilers like B> gcc -Wundef warn about it, and some non-C compilers like gcc -Wundef B> -Werror fail on it. The bug is sometimes hidden by -Wno-system-headers, B> but FreeBSD wants to detect bugs in system headers so it sets B> -Wsystem-headers at WARNS >= 1, and then the buggy compilers find this B> non-bug in system headers. The result is uglification of many system B> headers to use if `defined(__FOO) && ...' instead of depending on this B> standard and useful feature.
Shouldn't we then remove -Wundef from CWARNFLAGS in kern.mk? -- Totus tuus, Glebius. _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
